search

vicoapp / vico

Mac Programmers Text Editor
http://www.vicoapp.com/
658 stars 89 forks source link

Allow theming of the completion popup window. #48

Open jordwalke opened 11 years ago

jordwalke commented 11 years ago

I hear there is some special casing in Vico's code that tries to match the color scheme. (I'd love a link to that part of the code). Some might think that's a little too magical (and I agree) but I think most people would definitely settle for it to be controlled by a special colorscheme property. That might be easier as well.

Shadowfiend commented 11 years ago

The relevant code (commented out) is @ https://github.com/vicoapp/vico/blob/master/app/ViCompletionController.m#L64 . There's no clear indication as to why it was commented out, but I'm guessing it wasn't working quite as intended/complete.

Are you thinking a color scheme specifically for the controller, or are you thinking you could specify the colors in all color schemes with a set of properties for the color schemes?

I could go for the latter, where we would fall back on some default properties from the scheme when the special properties weren't present.

jordwalke commented 11 years ago

Yes, the latter (being able to specify them in color schemes) - special properties in the Textmate colorscheme file that no other editor pays regard to.

Shadowfiend commented 11 years ago

Sounds solid. I think it should be reasonably straightforward.