vicoapp / vico

Mac Programmers Text Editor
http://www.vicoapp.com/
658 stars 89 forks source link

Turning off `Show line numbers` causes document to display only one line. #62

Closed peterkovacs closed 11 years ago

peterkovacs commented 11 years ago

If you turn off line numbers in the preferences, new files that are loaded only show their first line.

image

With line numbers turned back on, the full file displays properly:

image

Shadowfiend commented 11 years ago

Hah! Notably, it seems like this is a load-time issue. Toggling line numbers won't blow away the other lines of an already-open file, and won't bring back the other lines of an already-poorly-loaded file. I'll look into it.

peterkovacs commented 11 years ago

Yeah, I agree. Unfortunately I don't know ObjC so my tracking down the bug has so far been unfruitful.

Of course, since I've been running with line numbers on all day, I'm starting to like it! Especially the relative line numbers. :)

Shadowfiend commented 11 years ago

Well… This is downright bizarre… I reproduced this on my work machine, but my home machine doesn't seem to have the problem. It's possible it's already been fixed by a different change.

What branch are you running off of?

peterkovacs commented 11 years ago

I was running off vico/master.

Using XCode 5.0 on OS X 10.8.5

Shadowfiend commented 11 years ago

Update here, I managed to reproduce this, and then I didn't… Which is a bit odd. I'll be trying to take some time to circle back to this in the next week or two.

peterkovacs commented 11 years ago

FWIW, I was able to reproduce this again locally using the latest master branch.

Shadowfiend commented 11 years ago

Awesome, thanks for mentioning that. Hopefully my next attempt to reproduce will actually work :)

Shadowfiend commented 11 years ago

headscratch Is all you do here turn off line numbers, open Vico, and then open a file?

peterkovacs commented 11 years ago

Well, in my case I pulled, ran make run and it happens whenever I don't have line numbers turned on.

Here is the console output during the run:

2013-11-09 08:33:45.678 Vico[10238:303] -[ViBundleItem initFromDictionary:inBundle:]:54: missing uuid in bundle item Subheader
2013-11-09 08:33:45.679 Vico[10238:303] -[ViBundleItem initFromDictionary:inBundle:]:54: missing uuid in bundle item Subheader
2013-11-09 08:33:45.680 Vico[10238:303] -[ViBundleItem initFromDictionary:inBundle:]:54: missing uuid in bundle item Subheader
2013-11-09 08:33:45.717 Vico[10238:303] -[ViBundleStore loadBundleFromDirectory:loadPluginCode:]:73: replacing bundle <ViBundle 0x7fe1c4423810: Treetop (83A8B700-143D-4BD6-B4EA-D73796E8F883)> with <ViBundle 0x7fe1c64321f0: Treetop (83A8B700-143D-4BD6-B4EA-D73796E8F883)>
2013-11-09 08:33:45.718 Vico[10238:303] -[ViBundleStore loadBundleFromDirectory:loadPluginCode:]:73: replacing bundle <ViBundle 0x7fe1c346edd0: Ack (10FB5B6B-E43F-4CB0-AEF3-933E74BF4A73)> with <ViBundle 0x7fe1c6434130: Ack (10FB5B6B-E43F-4CB0-AEF3-933E74BF4A73)>
2013-11-09 08:33:45.722 Vico[10238:303] -[ViBundleStore loadBundleFromDirectory:loadPluginCode:]:73: replacing bundle <ViBundle 0x7fe1c3471020: C (4675A940-6227-11D9-BFB1-000D93589AF6)> with <ViBundle 0x7fe1c643c1c0: C (4675A940-6227-11D9-BFB1-000D93589AF6)>
2013-11-09 08:33:45.726 Vico[10238:303] -[ViBundleSnippet initFromDictionary:inBundle:]:38: missing snippet content in bundle item { override in empty embedded
2013-11-09 08:33:45.738 Vico[10238:303] -[ViBundleStore loadBundleFromDirectory:loadPluginCode:]:73: replacing bundle <ViBundle 0x7fe1c8948920: Ruby on Rails (467A60E0-6227-11D9-BFB1-000D93589AF6)> with <ViBundle 0x7fe1c4202060: Ruby on Rails (467A60E0-6227-11D9-BFB1-000D93589AF6)>
2013-11-09 08:33:45.747 Vico[10238:303] -[ViBundleStore loadBundleFromDirectory:loadPluginCode:]:73: replacing bundle <ViBundle 0x7fe1c8980cb0: Ruby (467B298F-6227-11D9-BFB1-000D93589AF6)> with <ViBundle 0x7fe1c469b580: Ruby (467B298F-6227-11D9-BFB1-000D93589AF6)>
2013-11-09 08:33:45.762 Vico[10238:303] -[ViAppController eval:withParser:bindings:error:]:612: NuUndefinedSymbol: undefined symbol import while evaluating expression (progn (import Cocoa) (if (not (defined bundlePath)) (set bundlePath ("/Users/Shadowfiend/github/vico-ensime.vicobundle"))) (load (+ bundlePath "/ensime-project.nu")) (load "console") (global console ((NuConsoleWindowController alloc) init)) (console toggleConsole: nil) (if (defined project) ((project ensime-task) exit)) (global project (EnsimeProject ensimeProjectInDirectory: "/Users/Shadowfiend/openstudy-v2/")))
2013-11-09 08:33:45.763 Vico[10238:303] -[ViBundle loadPluginCode]:518: /Users/peter/Library/Application Support/Vico/Bundles/Shadowfiend-vico-ensime.vicobundle/main.nu: Got exception NuUndefinedSymbol: undefined symbol import while evaluating expression (progn (import Cocoa) (if (not (defined bundlePath)) (set bundlePath ("/Users/Shadowfiend/github/vico-ensime.vicobundle"))) (load (+ bundlePath "/ensime-project.nu")) (load "console") (global console ((NuConsoleWindowController alloc) init)) (console toggleConsole: nil) (if (defined project) ((project ensime-task) exit)) (global project (EnsimeProject ensimeProjectInDirectory: "/Users/Shadowfiend/openstudy-v2/")))
2013-11-09 08:33:45.790 Vico[10238:303] -[ViAppController applicationWillFinishLaunching:]:385: launched after 0.510182s
2013-11-09 08:33:46.455 Vico[10238:303] -[ViMark setDocument:]:240: got non-document <ViProject: 0x7fe1c3494de0> for mark <ViMark 0x7fe1c8824000 ((null)): <ViProject: 0x7fe1c3494de0>, 18446744073709551615:18446744073709551615 {9223372036854775807, 0}>
2013-11-09 08:33:46.462 Vico[10238:303] -[ViMark setDocument:]:240: got non-document <ViProject: 0x7fe1c3494de0> for mark <ViMark 0x7fe1c882d5e0 ((null)): <ViProject: 0x7fe1c3494de0>, 18446744073709551615:18446744073709551615 {9223372036854775807, 0}>
2013-11-09 08:33:46.751 Vico[10238:303] *** WARNING: -[NSImage compositeToPoint:operation:] is deprecated in MacOSX 10.8 and later. Please use -[NSImage drawAtPoint:fromRect:operation:fraction:] instead.
2013-11-09 08:33:46.751 Vico[10238:303] *** WARNING: -[NSImage compositeToPoint:fromRect:operation:] is deprecated in MacOSX 10.8 and later. Please use -[NSImage drawAtPoint:fromRect:operation:fraction:] instead.

Is it possible that my bundles are causing the problem?

Shadowfiend commented 11 years ago

No, I think all of that looks relatively normal. After posting this I saw a rendering glitch related to line numbers on an existing instance. I'll continue investigating. Will also try Ruby specifically.

Shadowfiend commented 11 years ago

Well, this one took me the better part of the day, but should be fixed on master with commit https://github.com/vicoapp/vico/commit/601066aa26d7b160e38d5c716970fa87e9912b4e , whose commit message explains the weirdness that was going on. Let me know if you're still seeing it!

peterkovacs commented 11 years ago

It's working for me now. Thanks!