search

vicoapp / vico

Mac Programmers Text Editor
http://www.vicoapp.com/
657 stars 89 forks source link

Make window opaque to normalize shadow. #63

Closed peteschaffner closed 10 years ago

peteschaffner commented 10 years ago

This takes the transparency out of windows, which was probably there to allow for alpha channels in theme backgrounds, but was also making for a lighter window shadow that made the app feel off from other native apps.

peteschaffner commented 10 years ago

See the difference here:

sshpvnzm9e-3000x3000

Shadowfiend commented 10 years ago

I wonder if the thing to do here would be to turn off opacity only if the theme we're using is has an alpha channel on its background………

Thoughts?

peteschaffner commented 10 years ago

Actually I believe that is exactly how TextMate 2 is handling this situation. If it is not too difficult to implement and more gotchas don't arise from this silent way of handling window drawing, I would say go for it. However, if it presents some problems I would vote to do away with window transparency in true Apple fashion.

There is one other way that might be worth looking into if we decide transparency is important, and that is to investigate how iTerm2 achieves the same effect. Both iTerm2 and Terminal.app support window transparency (and blur) and somehow achieve it w/out altering the window's shadow (almost as if there were a mask drawn around the textview). The only visual glitch that appears in these apps when using transparency is a slightly sharper looking titlebar corner (which bugs me too ... go figure):

slice 1

Shadowfiend commented 10 years ago

Try that on for size @peteschaffner ^.

peteschaffner commented 10 years ago

Closing in favor of #64.