search

vicolo-dev / chrono

A modern and powerful clock, alarms, timer and stopwatch app for Android!
GNU General Public License v3.0
412 stars 18 forks source link

Stopwatch: Last lap missing after pushing stop #255

Closed th23x closed 3 months ago

th23x commented 4 months ago

Sorry for the couple bugs/requests lately, but startin to use your cool app, I came across some :-)

Describe the bug

Last lap / remaining time not visible after stopping the stop watch - only previous laps are shown in the list.

To Reproduce

Steps to reproduce the behavior:

  1. Start stop watch
  2. Time a few laps
  3. Press stop
  4. See error - last lap/remaining time not shown

Expected behavior

Stopping should show all laps summing up to completed time.

Screenshots

https://github.com/vicolo-dev/chrono/assets/13735303/9a8bce0f-5717-4978-ae18-6d39197559a4

Smartphone Information

Additional context n/a

th23x commented 4 months ago

Maybe two more thoughts on this:

1) Clicking Lap button after Pause shows the missing lap - my expectation was, that the Pause equals Stop and thus would also create the final lap

2) If Pause should not equal Stop would expect a dedicated Stop button, creating the final lap - but seems to over complicate the user interface

AhsanSarwar45 commented 4 months ago

I think the way other apps handle this to always show the current lap in the list too, so laps always add up to total time, whether paused or running. Chrono only shows finished laps.

AhsanSarwar45 commented 3 months ago

I have updated it so it also shows the current lap at all times, which I think is the best behavior. It should be available in v0.5.2-beta1. Let me know if you face any issues.

th23x commented 3 months ago

Great - looks good in the newest release 👍