search

vicpenap / PrettyKit

PrettyKit for iOS is a small set of new widgets and UIKit subclasses that gives you a deeper UIKit customization. You will be able to change their background color, add gradients, shadows, etc.
http://vicpenap.github.com/PrettyKit
Other
1.22k stars 155 forks source link

Contribution required usage changes #42

Open feyyy opened 11 years ago

feyyy commented 11 years ago

Hi vicpenap, I actually planned to send you a private message but I did not find any way to do this so Im writing this post.

I am starting a new iOS application and I think PrettyKit is what i need for my application. My application requires animated insertion and deletion operations but PrettyKit is not support those operation as I see. I would love to make required enchantment on PrettyKit but my enchantments are changing usage of the PrettyKit a little bit.

Usage Changes; 1- User of this library will not need to call "prepareForTableView: indexPath:" method of PrettyTableViewCell under "tableView:cellForRowAtIndexPath:" method of UITableViewDelegate. 2- User needs to use a class named PrettyTableView instead UITableView

Enchantments; 1- PrettyKit will support adding and deleting cells with animation. (Corners of cells will animate like native UITableViewCell class). 2- PrettyCells can be designed in interfaceBuilder. (Their appearance will not be able to edited in interfaceBuilder but their content will be).

If you are okay with these changes I will upload my changes with their documentation soon.

Amnell commented 11 years ago

Support for animation is a much needed update. The usage changes seems fine I think. If everything works as intended this could be a start for a 2.0 branch.

TheAppleWizz commented 11 years ago

Is there any way you can share the files with me and can you add a textfield to the cell i have been trying to add a textfield to the pretty kit cell and for some reason i haven't been successful.

vicpenap commented 11 years ago

Using a custom UITableView class forces us to change UITableViewController's tableView property, and I don't know how safe it is when creating the view controller programmatically.