Submission for assignment 3 - Githubissues

victhangnguyen / df-frontend-2023

https://df-frontend-2023-self.vercel.app

0 stars 0 forks source link

Submission for assignment 3 #11

Open victhangnguyen opened 1 year ago

victhangnguyen commented 1 year ago

//Demo Link: https://df-frontend-2023-two.vercel.app/

Use Typescript to code dependent on Eslint's rules.
Create All of Types in types src/types.
Add the lint-stage and create husk Hook to check lint before git commit.
Add Dark/Light Mode function in Setting tab.

tienan92it commented 1 year ago

Hello @victhangnguyen , great work! Below is some feedback for your assignment.

Requirements

[x] All core functionalities present
[x] Proper TypeScript implementation
[x] No eslint warnings & errors
[x] Husky & lint-staged integration

Final result: ✅ passed 90% of requirements

Feedback

Enable noImplicitAny to reveal the implicit any types. https://github.com/victhangnguyen/df-frontend-2023/blob/65a556fc3208082ec635e6c197940411e1c0cb23/assignment-3/tsconfig.json#L18 https://github.com/victhangnguyen/df-frontend-2023/blob/65a556fc3208082ec635e6c197940411e1c0cb23/assignment-3/src/components/Modal/ConfirmationModal.tsx#L17 https://github.com/victhangnguyen/df-frontend-2023/blob/65a556fc3208082ec635e6c197940411e1c0cb23/assignment-3/src/components/Pagination/index.tsx#L44 https://github.com/victhangnguyen/df-frontend-2023/blob/65a556fc3208082ec635e6c197940411e1c0cb23/assignment-3/src/components/Table/index.tsx#L3-L4 ...
Should move type of component props to the component which it belongs to. https://github.com/victhangnguyen/df-frontend-2023/blob/65a556fc3208082ec635e6c197940411e1c0cb23/assignment-3/src/types/Button.tsx https://github.com/victhangnguyen/df-frontend-2023/blob/65a556fc3208082ec635e6c197940411e1c0cb23/assignment-3/src/types/Icon.tsx https://github.com/victhangnguyen/df-frontend-2023/blob/65a556fc3208082ec635e6c197940411e1c0cb23/assignment-3/src/types/Modal.tsx ...
Because you set the initial value for useState already, don't need to explicitly declare the type for it. https://github.com/victhangnguyen/df-frontend-2023/blob/65a556fc3208082ec635e6c197940411e1c0cb23/assignment-3/src/pages/Home/index.tsx#L16-L20 https://github.com/victhangnguyen/df-frontend-2023/blob/65a556fc3208082ec635e6c197940411e1c0cb23/assignment-3/src/pages/Home/index.tsx#L23-L30 ...