victhangnguyen / df-frontend-2023

https://df-frontend-2023-self.vercel.app
0 stars 0 forks source link

Submission for assignment 4 #19

Open victhangnguyen opened 1 year ago

victhangnguyen commented 1 year ago

Link Demon: https://df-frontend-2023-asm-4.vercel.app/book

tienan92it commented 1 year ago

Hello @victhangnguyen , well done!. Below is some feedback for your assignment.

Requirements

Final result: ✅ passed 90% of requirements

Feedback

  1. Folder naming is not consistent. It's better if in lowercases.

    Screenshot 2023-10-18 at 17 19 17
  2. Theme toggle doesn't sync states after refreshing.

    Screenshot 2023-10-18 at 17 21 41
  3. Search input doesn't keep query term after redirecting, so User won't know how to go back the original book list.