search

victims / victims-lib-java

The victims library containing the hashing logic for java specific artifacts.
GNU Affero General Public License v3.0
5 stars 8 forks source link

Broke --jar-compare with 87efe818cae767676ce1d0855c785282efb200a8 #28

Closed msavy closed 10 years ago

msavy commented 10 years ago

Hi,

The commit https://github.com/victims/victims-client-java/commit/87efe818cae767676ce1d0855c785282efb200a8 seems to have broken --jar-compare, as one part of the code expects --jar-compare ArgA ArgB and another expects --jar-compare "ArgA,ArgB"

So, either style you use causes breakage.

See:

https://github.com/victims/victims-client-java/blob/87efe818cae767676ce1d0855c785282efb200a8/src/main/java/com/redhat/victims/cli/commands/CompareCommand.java#L66

https://github.com/victims/victims-client-java/blob/87efe818cae767676ce1d0855c785282efb200a8/src/main/java/com/redhat/victims/cli/Main.java#L269

msavy commented 10 years ago

Sorry, I put this into the wrong issue tracker. Transferring it to the correct one...