WIP: Openshift 3.x updates

victims / victims-web

The victims web application.

GNU Affero General Public License v3.0

8 stars 5 forks source link

WIP: Openshift 3.x updates #149

Closed ashcrow closed 7 years ago

ashcrow commented 7 years ago

Based on: https://github.com/victims/victims-web/pull/148

ashcrow commented 7 years ago

@jasinner looks like I'll need to re-add the from victims_web. portion to imports. Was that causing a problem with OS3 or what is just to make running it locally easier (IE: without setting PYTHONPATH).

jasinner commented 7 years ago

Sorry the pull request was a bit premature. I had not got it fully working in OCP, but I'm not sure why not. It was working locally for me like this, without 'from victims_web', just the test where not passing. When I build with s2i I was adding 'src/victims_web' as a 'context dir' parameter.

abn commented 7 years ago

I have made a few changes in PR #150 this will improve package handling etc. I'd recommend closing this one and the previous PR in favour of that one. Granted that does not "complete" the OpenShift migration but its a step in the right direction.