search

victimsnino / ReactivePlusPlus

Implementation of async observable/observer (Reactive Programming) in C++ with care about performance and templates in mind in ReactiveX approach
https://victimsnino.github.io/ReactivePlusPlus/v2/docs/html/index.html
Boost Software License 1.0
246 stars 28 forks source link

Fix deadlocks in operators related to is_disposed #661

Closed victimsnino closed 1 month ago

victimsnino commented 1 month ago

Summary by CodeRabbit

coderabbitai[bot] commented 1 month ago
📝 Walkthrough ## Walkthrough The changes in this pull request primarily modify the `base_disposable_impl` class to provide a default implementation for the `base_dispose_impl` method, making it optional for derived classes to implement. Additionally, several classes in the `rpp::operators::details` namespace are updated to improve memory management and disposal handling. New test cases are added to ensure that specific operators do not deadlock when the observer is disposed. ## Changes | File Path | Change Summary | |--------------------------------------------------------|---------------------------------------------------------------------------------------------------------------------------------------------------------------------| | `src/rpp/rpp/disposables/details/base_disposable.hpp` | - Modified `base_dispose_impl` method to provide a default implementation, making it optional for derived classes. | | `src/rpp/rpp/operators/debounce.hpp` | - Updated `debounce_state` to inherit from `enable_wrapper_from_this` and `base_disposable`.
- Modified `schedule` method to use `this->wrapper_from_this().lock()`. | | `src/rpp/rpp/operators/details/combining_strategy.hpp` | - Updated `combining_state` to inherit from `enable_wrapper_from_this` and `base_disposable`.
- Modified `subscribe_impl` method for better memory management. | | `src/rpp/rpp/operators/merge.hpp` | - Updated `merge_observer_base_strategy` to change `is_disposed` method to return the disposed state of the disposable wrapper. | | `src/tests/rpp/test_combine_latest.cpp` | - Added test case to verify `combine_latest` does not deadlock when the observer is disposed. | | `src/tests/rpp/test_debounce.cpp` | - Added test case to verify `debounce` does not deadlock when the observer is disposed. | | `src/tests/rpp/test_merge.cpp` | - Added test case to verify `merge` does not deadlock when the observer is disposed. | | `src/tests/rpp/test_zip.cpp` | - Added test case to verify `zip` does not deadlock when the observer is disposed. | ## Possibly related PRs - **#640**: Modifications to the `concat_state_t` class, dealing with disposables, similar to changes in `base_disposable_impl`. - **#644**: Removal of resource disposal calls in error handling, related to disposal logic in `base_dispose_impl`. - **#649**: Transition to the Doctest framework affecting testing of disposables, relevant to default implementations of disposal methods. - **#657**: New test case added to enhance coverage related to observer behavior, possibly interacting with disposal logic. > 🐰 In the meadow where bunnies play, > A change was made, hip-hip-hooray! > With disposables now light as air, > No more worries, no more care. > Tests are hopping, all in line, > Ensuring our code will brightly shine! > 🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
🪧 Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit , please review it.` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (Invoked using PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. ### Other keywords and placeholders - Add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. - Add `@coderabbitai summary` to generate the high-level summary at a specific location in the PR description. - Add `@coderabbitai` anywhere in the PR title to generate the title automatically. ### CodeRabbit Configuration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](http://discord.gg/coderabbit) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
github-actions[bot] commented 1 month ago

BENCHMARK RESULTS (AUTOGENERATED)

## ci-ubuntu-gcc
### General name | rxcpp | rpp | prev rpp | ratio --- | --- | --- | --- | --- Subscribe empty callbacks to empty observable | 301.75 ns | 2.16 ns| 2.16 ns | 1.00 Subscribe empty callbacks to empty observable via pipe operator | 305.99 ns | 2.16 ns| 2.16 ns | 1.00
### Sources name | rxcpp | rpp | prev rpp | ratio --- | --- | --- | --- | --- from array of 1 - create + subscribe + immediate | 685.83 ns | 0.31 ns| 0.31 ns | 1.00 from array of 1 - create + subscribe + current_thread | 1034.89 ns | 3.70 ns| 3.71 ns | 1.00 concat_as_source of just(1 immediate) create + subscribe | 2251.70 ns | 142.08 ns| 151.49 ns | 0.94 defer from array of 1 - defer + create + subscribe + immediate | 733.08 ns | 0.31 ns| 0.31 ns | 1.00 interval - interval + take(3) + subscribe + immediate | 2193.41 ns | 59.23 ns| 59.23 ns | 1.00 interval - interval + take(3) + subscribe + current_thread | 2991.44 ns | 32.42 ns| 32.43 ns | 1.00 from array of 1 - create + as_blocking + subscribe + new_thread | 29326.87 ns | 27389.10 ns| 27577.11 ns | 0.99 from array of 1000 - create + as_blocking + subscribe + new_thread | 37373.34 ns | 51518.85 ns| 48957.91 ns | 1.05 concat_as_source of just(1 immediate) and just(1,2 immediate)create + subscribe | 3526.54 ns | 213.99 ns| 213.76 ns | 1.00
### Filtering Operators name | rxcpp | rpp | prev rpp | ratio --- | --- | --- | --- | --- immediate_just+take(1)+subscribe | 1077.20 ns | 0.31 ns| 0.31 ns | 1.00 immediate_just+filter(true)+subscribe | 840.65 ns | 0.31 ns| 0.31 ns | 1.00 immediate_just(1,2)+skip(1)+subscribe | 994.91 ns | 0.31 ns| 0.31 ns | 1.00 immediate_just(1,1,2)+distinct_until_changed()+subscribe | 846.63 ns | 0.31 ns| 0.31 ns | 1.00 immediate_just(1,2)+first()+subscribe | 1246.75 ns | 0.31 ns| 0.31 ns | 1.00 immediate_just(1,2)+last()+subscribe | 917.73 ns | 0.31 ns| 0.31 ns | 1.00 immediate_just+take_last(1)+subscribe | 1136.97 ns | 18.20 ns| 17.91 ns | 1.02 immediate_just(1,2,3)+element_at(1)+subscribe | 830.58 ns | 0.31 ns| 0.31 ns | 1.00
### Schedulers name | rxcpp | rpp | prev rpp | ratio --- | --- | --- | --- | --- immediate scheduler create worker + schedule | 264.95 ns | 2.16 ns| 2.16 ns | 1.00 current_thread scheduler create worker + schedule | 364.37 ns | 5.87 ns| 5.57 ns | 1.05 current_thread scheduler create worker + schedule + recursive schedule | 821.40 ns | 56.16 ns| 56.33 ns | 1.00
### Transforming Operators name | rxcpp | rpp | prev rpp | ratio --- | --- | --- | --- | --- immediate_just+map(v*2)+subscribe | 886.42 ns | 0.31 ns| 0.31 ns | 1.00 immediate_just+scan(10, std::plus)+subscribe | 894.30 ns | 0.31 ns| 0.31 ns | 1.00 immediate_just+flat_map(immediate_just(v*2))+subscribe | 2381.32 ns | 191.25 ns| 208.73 ns | 0.92 immediate_just+buffer(2)+subscribe | 1535.36 ns | 13.90 ns| 13.59 ns | 1.02 immediate_just+window(2)+subscribe + subscsribe inner | 2435.66 ns | 1322.33 ns| 1276.86 ns | 1.04
### Conditional Operators name | rxcpp | rpp | prev rpp | ratio --- | --- | --- | --- | --- immediate_just+take_while(false)+subscribe | 832.45 ns | -| - | 0.00 immediate_just+take_while(true)+subscribe | 855.21 ns | 0.31 ns| 0.31 ns | 1.00
### Utility Operators name | rxcpp | rpp | prev rpp | ratio --- | --- | --- | --- | --- immediate_just(1)+subscribe_on(immediate)+subscribe | 1982.37 ns | 0.31 ns| 0.31 ns | 1.00
### Combining Operators name | rxcpp | rpp | prev rpp | ratio --- | --- | --- | --- | --- immediate_just(immediate_just(1), immediate_just(1)) + merge() + subscribe | 3454.31 ns | 236.67 ns| 259.63 ns | 0.91 immediate_just(1) + merge_with(immediate_just(2)) + subscribe | 3871.26 ns | 190.95 ns| 215.45 ns | 0.89 immediate_just(1) + with_latest_from(immediate_just(2)) + subscribe | - | 178.74 ns| 178.41 ns | 1.00 immediate_just(immediate_just(1),immediate_just(1)) + switch_on_next() + subscribe | 3481.76 ns | 1200.81 ns| 1238.08 ns | 0.97 immediate_just(1) + zip(immediate_just(2)) + subscribe | 2191.14 ns | 223.05 ns| 202.41 ns | 1.10
### Subjects name | rxcpp | rpp | prev rpp | ratio --- | --- | --- | --- | --- publish_subject with 1 observer - on_next | 34.49 ns | 14.64 ns| 14.72 ns | 0.99 subscribe 100 observers to publish_subject | 198279.17 ns | 15978.25 ns| 15761.87 ns | 1.01 100 on_next to 100 observers to publish_subject | 26967.29 ns | 17221.73 ns| 19484.39 ns | 0.88
### Scenarios name | rxcpp | rpp | prev rpp | ratio --- | --- | --- | --- | --- basic sample | 1371.83 ns | 12.66 ns| 13.90 ns | 0.91 basic sample with immediate scheduler | 1376.97 ns | 5.55 ns| 5.55 ns | 1.00
### Aggregating Operators name | rxcpp | rpp | prev rpp | ratio --- | --- | --- | --- | --- immediate_just+reduce(10, std::plus)+subscribe | 913.43 ns | 0.31 ns| 0.31 ns | 1.00
### Error Handling Operators name | rxcpp | rpp | prev rpp | ratio --- | --- | --- | --- | --- create(on_next(1), on_error())+on_error_resume_next(immediate_just(2)))+subscribe | 2071.26 ns | 915.58 ns| 937.98 ns | 0.98 create(on_error())+retry(1)+subscribe | 645.84 ns | 120.34 ns| 122.33 ns | 0.98
## ci-macos
### General name | rxcpp | rpp | prev rpp | ratio --- | --- | --- | --- | --- Subscribe empty callbacks to empty observable | 990.13 ns | 3.99 ns| 3.92 ns | 1.02 Subscribe empty callbacks to empty observable via pipe operator | 981.28 ns | 3.96 ns| 3.90 ns | 1.01
### Sources name | rxcpp | rpp | prev rpp | ratio --- | --- | --- | --- | --- from array of 1 - create + subscribe + immediate | 1940.80 ns | 0.23 ns| 0.24 ns | 0.97 from array of 1 - create + subscribe + current_thread | 2471.99 ns | 32.48 ns| 33.70 ns | 0.96 concat_as_source of just(1 immediate) create + subscribe | 5462.82 ns | 435.47 ns| 423.17 ns | 1.03 defer from array of 1 - defer + create + subscribe + immediate | 1947.97 ns | 0.23 ns| 0.24 ns | 0.97 interval - interval + take(3) + subscribe + immediate | 4950.96 ns | 114.89 ns| 116.93 ns | 0.98 interval - interval + take(3) + subscribe + current_thread | 6222.34 ns | 95.87 ns| 104.13 ns | 0.92 from array of 1 - create + as_blocking + subscribe + new_thread | 81740.38 ns | 81089.92 ns| 74958.47 ns | 1.08 from array of 1000 - create + as_blocking + subscribe + new_thread | 87654.00 ns | 85902.23 ns| 87103.38 ns | 0.99 concat_as_source of just(1 immediate) and just(1,2 immediate)create + subscribe | 8181.09 ns | 590.03 ns| 613.72 ns | 0.96
### Filtering Operators name | rxcpp | rpp | prev rpp | ratio --- | --- | --- | --- | --- immediate_just+take(1)+subscribe | 2879.97 ns | 0.25 ns| 0.23 ns | 1.09 immediate_just+filter(true)+subscribe | 2114.70 ns | 0.23 ns| 0.23 ns | 1.00 immediate_just(1,2)+skip(1)+subscribe | 2746.78 ns | 0.23 ns| 0.23 ns | 1.00 immediate_just(1,1,2)+distinct_until_changed()+subscribe | 2071.95 ns | 0.47 ns| 0.47 ns | 1.00 immediate_just(1,2)+first()+subscribe | 3172.37 ns | 0.23 ns| 0.23 ns | 1.00 immediate_just(1,2)+last()+subscribe | 2377.24 ns | 0.23 ns| 0.23 ns | 1.00 immediate_just+take_last(1)+subscribe | 3018.53 ns | 0.23 ns| 0.23 ns | 1.00 immediate_just(1,2,3)+element_at(1)+subscribe | 2118.51 ns | 0.23 ns| 0.23 ns | 1.00
### Schedulers name | rxcpp | rpp | prev rpp | ratio --- | --- | --- | --- | --- immediate scheduler create worker + schedule | 865.29 ns | 4.17 ns| 4.36 ns | 0.96 current_thread scheduler create worker + schedule | 1192.26 ns | 36.81 ns| 39.79 ns | 0.93 current_thread scheduler create worker + schedule + recursive schedule | 2045.10 ns | 201.70 ns| 222.03 ns | 0.91
### Transforming Operators name | rxcpp | rpp | prev rpp | ratio --- | --- | --- | --- | --- immediate_just+map(v*2)+subscribe | 2141.43 ns | 4.43 ns| 4.43 ns | 1.00 immediate_just+scan(10, std::plus)+subscribe | 2361.15 ns | 0.47 ns| 0.47 ns | 1.00 immediate_just+flat_map(immediate_just(v*2))+subscribe | 5203.96 ns | 495.06 ns| 622.13 ns | 0.80 immediate_just+buffer(2)+subscribe | 2440.82 ns | 64.96 ns| 64.51 ns | 1.01 immediate_just+window(2)+subscribe + subscsribe inner | 5328.98 ns | 2323.16 ns| 2356.96 ns | 0.99
### Conditional Operators name | rxcpp | rpp | prev rpp | ratio --- | --- | --- | --- | --- immediate_just+take_while(false)+subscribe | 2108.34 ns | -| - | 0.00 immediate_just+take_while(true)+subscribe | 2126.04 ns | 0.23 ns| 0.23 ns | 1.00
### Utility Operators name | rxcpp | rpp | prev rpp | ratio --- | --- | --- | --- | --- immediate_just(1)+subscribe_on(immediate)+subscribe | 4912.90 ns | 4.90 ns| 4.90 ns | 1.00
### Combining Operators name | rxcpp | rpp | prev rpp | ratio --- | --- | --- | --- | --- immediate_just(immediate_just(1), immediate_just(1)) + merge() + subscribe | 7467.04 ns | 592.19 ns| 802.80 ns | 0.74 immediate_just(1) + merge_with(immediate_just(2)) + subscribe | 8433.31 ns | 505.01 ns| 640.88 ns | 0.79 immediate_just(1) + with_latest_from(immediate_just(2)) + subscribe | - | 579.76 ns| 595.10 ns | 0.97 immediate_just(immediate_just(1),immediate_just(1)) + switch_on_next() + subscribe | 7979.43 ns | 1897.80 ns| 1953.34 ns | 0.97 immediate_just(1) + zip(immediate_just(2)) + subscribe | 5146.32 ns | 926.61 ns| 792.91 ns | 1.17
### Subjects name | rxcpp | rpp | prev rpp | ratio --- | --- | --- | --- | --- publish_subject with 1 observer - on_next | 72.36 ns | 46.64 ns| 48.98 ns | 0.95 subscribe 100 observers to publish_subject | 338723.00 ns | 39072.82 ns| 40815.78 ns | 0.96 100 on_next to 100 observers to publish_subject | 52318.00 ns | 18246.46 ns| 18004.50 ns | 1.01
### Scenarios name | rxcpp | rpp | prev rpp | ratio --- | --- | --- | --- | --- basic sample | 2703.57 ns | 65.75 ns| 70.89 ns | 0.93 basic sample with immediate scheduler | 2715.43 ns | 18.30 ns| 18.55 ns | 0.99
### Aggregating Operators name | rxcpp | rpp | prev rpp | ratio --- | --- | --- | --- | --- immediate_just+reduce(10, std::plus)+subscribe | 2259.90 ns | 0.23 ns| 0.23 ns | 1.00
### Error Handling Operators name | rxcpp | rpp | prev rpp | ratio --- | --- | --- | --- | --- create(on_next(1), on_error())+on_error_resume_next(immediate_just(2)))+subscribe | 6126.33 ns | 3730.20 ns| 3874.78 ns | 0.96 create(on_error())+retry(1)+subscribe | 1723.73 ns | 346.25 ns| 362.62 ns | 0.95
## ci-ubuntu-clang
### General name | rxcpp | rpp | prev rpp | ratio --- | --- | --- | --- | --- Subscribe empty callbacks to empty observable | 266.85 ns | 1.54 ns| 0.88 ns | 1.76 Subscribe empty callbacks to empty observable via pipe operator | 266.63 ns | 1.54 ns| 0.88 ns | 1.76
### Sources name | rxcpp | rpp | prev rpp | ratio --- | --- | --- | --- | --- from array of 1 - create + subscribe + immediate | 577.84 ns | 0.31 ns| 0.31 ns | 1.00 from array of 1 - create + subscribe + current_thread | 805.80 ns | 4.01 ns| 4.33 ns | 0.93 concat_as_source of just(1 immediate) create + subscribe | 2341.10 ns | 185.02 ns| 182.35 ns | 1.01 defer from array of 1 - defer + create + subscribe + immediate | 776.01 ns | 0.31 ns| 0.31 ns | 1.00 interval - interval + take(3) + subscribe + immediate | 2212.27 ns | 58.32 ns| 58.40 ns | 1.00 interval - interval + take(3) + subscribe + current_thread | 3188.34 ns | 30.86 ns| 30.86 ns | 1.00 from array of 1 - create + as_blocking + subscribe + new_thread | 30137.13 ns | 27835.12 ns| 27652.10 ns | 1.01 from array of 1000 - create + as_blocking + subscribe + new_thread | 38139.24 ns | 33730.33 ns| 35166.85 ns | 0.96 concat_as_source of just(1 immediate) and just(1,2 immediate)create + subscribe | 3708.41 ns | 304.70 ns| 304.62 ns | 1.00
### Filtering Operators name | rxcpp | rpp | prev rpp | ratio --- | --- | --- | --- | --- immediate_just+take(1)+subscribe | 1152.62 ns | 0.31 ns| 0.31 ns | 1.00 immediate_just+filter(true)+subscribe | 842.24 ns | 0.31 ns| 0.31 ns | 1.00 immediate_just(1,2)+skip(1)+subscribe | 1087.08 ns | 0.31 ns| 0.31 ns | 1.00 immediate_just(1,1,2)+distinct_until_changed()+subscribe | 865.83 ns | 0.31 ns| 0.62 ns | 0.50 immediate_just(1,2)+first()+subscribe | 1403.72 ns | 0.31 ns| 0.31 ns | 1.00 immediate_just(1,2)+last()+subscribe | 996.50 ns | 0.31 ns| 0.31 ns | 1.00 immediate_just+take_last(1)+subscribe | 1196.91 ns | 0.31 ns| 0.31 ns | 1.00 immediate_just(1,2,3)+element_at(1)+subscribe | 864.67 ns | 0.31 ns| 0.31 ns | 1.00
### Schedulers name | rxcpp | rpp | prev rpp | ratio --- | --- | --- | --- | --- immediate scheduler create worker + schedule | 278.45 ns | 1.54 ns| 0.88 ns | 1.76 current_thread scheduler create worker + schedule | 392.51 ns | 4.60 ns| 4.94 ns | 0.93 current_thread scheduler create worker + schedule + recursive schedule | 855.05 ns | 56.20 ns| 56.21 ns | 1.00
### Transforming Operators name | rxcpp | rpp | prev rpp | ratio --- | --- | --- | --- | --- immediate_just+map(v*2)+subscribe | 837.26 ns | 0.31 ns| 0.31 ns | 1.00 immediate_just+scan(10, std::plus)+subscribe | 962.35 ns | 0.31 ns| 0.31 ns | 1.00 immediate_just+flat_map(immediate_just(v*2))+subscribe | 2271.46 ns | 228.33 ns| 172.99 ns | 1.32 immediate_just+buffer(2)+subscribe | 1525.11 ns | 13.90 ns| 14.20 ns | 0.98 immediate_just+window(2)+subscribe + subscsribe inner | 2474.81 ns | 927.39 ns| 928.30 ns | 1.00
### Conditional Operators name | rxcpp | rpp | prev rpp | ratio --- | --- | --- | --- | --- immediate_just+take_while(false)+subscribe | 847.35 ns | -| - | 0.00 immediate_just+take_while(true)+subscribe | 866.17 ns | 0.31 ns| 0.31 ns | 1.00
### Utility Operators name | rxcpp | rpp | prev rpp | ratio --- | --- | --- | --- | --- immediate_just(1)+subscribe_on(immediate)+subscribe | 2000.37 ns | 0.31 ns| 0.31 ns | 1.00
### Combining Operators name | rxcpp | rpp | prev rpp | ratio --- | --- | --- | --- | --- immediate_just(immediate_just(1), immediate_just(1)) + merge() + subscribe | 3284.02 ns | 291.22 ns| 201.39 ns | 1.45 immediate_just(1) + merge_with(immediate_just(2)) + subscribe | 3723.68 ns | 220.69 ns| 160.56 ns | 1.37 immediate_just(1) + with_latest_from(immediate_just(2)) + subscribe | - | 198.92 ns| 200.77 ns | 0.99 immediate_just(immediate_just(1),immediate_just(1)) + switch_on_next() + subscribe | 3372.45 ns | 846.28 ns| 863.63 ns | 0.98 immediate_just(1) + zip(immediate_just(2)) + subscribe | 2251.17 ns | 198.06 ns| 160.59 ns | 1.23
### Subjects name | rxcpp | rpp | prev rpp | ratio --- | --- | --- | --- | --- publish_subject with 1 observer - on_next | 54.09 ns | 18.21 ns| 17.83 ns | 1.02 subscribe 100 observers to publish_subject | 215262.40 ns | 16047.95 ns| 15973.14 ns | 1.00 100 on_next to 100 observers to publish_subject | 37551.50 ns | 20680.58 ns| 17364.46 ns | 1.19
### Scenarios name | rxcpp | rpp | prev rpp | ratio --- | --- | --- | --- | --- basic sample | 1293.97 ns | 11.55 ns| 11.73 ns | 0.98 basic sample with immediate scheduler | 1303.21 ns | 6.17 ns| 6.17 ns | 1.00
### Aggregating Operators name | rxcpp | rpp | prev rpp | ratio --- | --- | --- | --- | --- immediate_just+reduce(10, std::plus)+subscribe | 996.32 ns | 0.31 ns| 0.31 ns | 1.00
### Error Handling Operators name | rxcpp | rpp | prev rpp | ratio --- | --- | --- | --- | --- create(on_next(1), on_error())+on_error_resume_next(immediate_just(2)))+subscribe | 2256.41 ns | 1007.33 ns| 1030.32 ns | 0.98 create(on_error())+retry(1)+subscribe | 656.72 ns | 157.19 ns| 156.94 ns | 1.00
## ci-windows
### General name | rxcpp | rpp | prev rpp | ratio --- | --- | --- | --- | --- Subscribe empty callbacks to empty observable | 559.56 ns | 4.01 ns| 4.32 ns | 0.93 Subscribe empty callbacks to empty observable via pipe operator | 575.97 ns | 4.01 ns| 4.32 ns | 0.93
### Sources name | rxcpp | rpp | prev rpp | ratio --- | --- | --- | --- | --- from array of 1 - create + subscribe + immediate | 1148.00 ns | 9.71 ns| 9.71 ns | 1.00 from array of 1 - create + subscribe + current_thread | 1423.55 ns | 17.89 ns| 17.95 ns | 1.00 concat_as_source of just(1 immediate) create + subscribe | 3699.67 ns | 233.25 ns| 244.29 ns | 0.95 defer from array of 1 - defer + create + subscribe + immediate | 1198.47 ns | 9.46 ns| 9.43 ns | 1.00 interval - interval + take(3) + subscribe + immediate | 3381.66 ns | 145.68 ns| 145.37 ns | 1.00 interval - interval + take(3) + subscribe + current_thread | 3453.64 ns | 64.35 ns| 65.91 ns | 0.98 from array of 1 - create + as_blocking + subscribe + new_thread | 120387.50 ns | 114180.00 ns| 112263.64 ns | 1.02 from array of 1000 - create + as_blocking + subscribe + new_thread | 129425.00 ns | 131677.78 ns| 132437.50 ns | 0.99 concat_as_source of just(1 immediate) and just(1,2 immediate)create + subscribe | 5369.06 ns | 312.73 ns| 332.85 ns | 0.94
### Filtering Operators name | rxcpp | rpp | prev rpp | ratio --- | --- | --- | --- | --- immediate_just+take(1)+subscribe | 1798.27 ns | 25.28 ns| 25.28 ns | 1.00 immediate_just+filter(true)+subscribe | 1321.73 ns | 24.35 ns| 24.35 ns | 1.00 immediate_just(1,2)+skip(1)+subscribe | 1735.20 ns | 24.06 ns| 24.07 ns | 1.00 immediate_just(1,1,2)+distinct_until_changed()+subscribe | 1352.46 ns | 28.99 ns| 28.99 ns | 1.00 immediate_just(1,2)+first()+subscribe | 2352.35 ns | 22.82 ns| 22.83 ns | 1.00 immediate_just(1,2)+last()+subscribe | 1784.49 ns | 24.06 ns| 24.07 ns | 1.00 immediate_just+take_last(1)+subscribe | 1995.52 ns | 70.76 ns| 72.06 ns | 0.98 immediate_just(1,2,3)+element_at(1)+subscribe | 1338.11 ns | 27.45 ns| 28.57 ns | 0.96
### Schedulers name | rxcpp | rpp | prev rpp | ratio --- | --- | --- | --- | --- immediate scheduler create worker + schedule | 480.39 ns | 6.17 ns| 6.48 ns | 0.95 current_thread scheduler create worker + schedule | 651.97 ns | 13.92 ns| 13.93 ns | 1.00 current_thread scheduler create worker + schedule + recursive schedule | 1090.37 ns | 103.31 ns| 105.85 ns | 0.98
### Transforming Operators name | rxcpp | rpp | prev rpp | ratio --- | --- | --- | --- | --- immediate_just+map(v*2)+subscribe | 1307.22 ns | 24.37 ns| 24.35 ns | 1.00 immediate_just+scan(10, std::plus)+subscribe | 1448.11 ns | 26.84 ns| 26.55 ns | 1.01 immediate_just+flat_map(immediate_just(v*2))+subscribe | 3443.80 ns | 270.07 ns| 349.68 ns | 0.77 immediate_just+buffer(2)+subscribe | 2625.06 ns | 70.12 ns| 69.08 ns | 1.02 immediate_just+window(2)+subscribe + subscsribe inner | 4077.22 ns | 1324.30 ns| 1347.09 ns | 0.98
### Conditional Operators name | rxcpp | rpp | prev rpp | ratio --- | --- | --- | --- | --- immediate_just+take_while(false)+subscribe | 1317.40 ns | 23.12 ns| 23.12 ns | 1.00 immediate_just+take_while(true)+subscribe | 1313.04 ns | 24.36 ns| 24.35 ns | 1.00
### Utility Operators name | rxcpp | rpp | prev rpp | ratio --- | --- | --- | --- | --- immediate_just(1)+subscribe_on(immediate)+subscribe | 3493.20 ns | 11.11 ns| 11.10 ns | 1.00
### Combining Operators name | rxcpp | rpp | prev rpp | ratio --- | --- | --- | --- | --- immediate_just(immediate_just(1), immediate_just(1)) + merge() + subscribe | 5016.67 ns | 310.32 ns| 420.62 ns | 0.74 immediate_just(1) + merge_with(immediate_just(2)) + subscribe | 5402.43 ns | 275.13 ns| 326.95 ns | 0.84 immediate_just(1) + with_latest_from(immediate_just(2)) + subscribe | - | 303.61 ns| 309.32 ns | 0.98 immediate_just(immediate_just(1),immediate_just(1)) + switch_on_next() + subscribe | 5208.13 ns | 933.27 ns| 946.83 ns | 0.99 immediate_just(1) + zip(immediate_just(2)) + subscribe | 3539.22 ns | 574.22 ns| 565.80 ns | 1.01
### Subjects name | rxcpp | rpp | prev rpp | ratio --- | --- | --- | --- | --- publish_subject with 1 observer - on_next | 36.50 ns | 20.24 ns| 19.46 ns | 1.04 subscribe 100 observers to publish_subject | 274025.00 ns | 27035.71 ns| 29477.14 ns | 0.92 100 on_next to 100 observers to publish_subject | 54910.53 ns | 32662.16 ns| 32584.37 ns | 1.00
### Scenarios name | rxcpp | rpp | prev rpp | ratio --- | --- | --- | --- | --- basic sample | 1873.94 ns | 101.59 ns| 101.66 ns | 1.00 basic sample with immediate scheduler | 1875.51 ns | 73.93 ns| 74.83 ns | 0.99
### Aggregating Operators name | rxcpp | rpp | prev rpp | ratio --- | --- | --- | --- | --- immediate_just+reduce(10, std::plus)+subscribe | 1470.11 ns | 24.97 ns| 24.99 ns | 1.00
### Error Handling Operators name | rxcpp | rpp | prev rpp | ratio --- | --- | --- | --- | --- create(on_next(1), on_error())+on_error_resume_next(immediate_just(2)))+subscribe | 2151.40 ns | 246.06 ns| 252.61 ns | 0.97 create(on_error())+retry(1)+subscribe | 1459.57 ns | 191.36 ns| 191.97 ns | 1.00
codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 98.28%. Comparing base (302afa1) to head (1862c56). Report is 1 commits behind head on v2.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## v2 #661 +/- ## ========================================== + Coverage 98.27% 98.28% +0.01% ========================================== Files 154 154 Lines 7670 7717 +47 ========================================== + Hits 7538 7585 +47 Misses 132 132 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

sonarcloud[bot] commented 1 month ago

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

thorstink commented 1 month ago

FYI, in this project (https://github.com/thorstink/Symmetri/tree/feature/gui) I was stuck on a few-months old version of rpp v2, because it would deadlock if I upgraded to a more recent version. This update finally seemed to have fixed it :) Thanks!

(I couldn't really create a nice isolated example for you, but not needed anymore :) )

victimsnino commented 1 month ago

FYI, in this project (https://github.com/thorstink/Symmetri/tree/feature/gui) I was stuck on a few-months old version of rpp v2, because it would deadlock if I upgraded to a more recent version. This update finally seemed to have fixed it :) Thanks!

(I couldn't really create a nice isolated example for you, but not needed anymore :) )

Glad to hear it! But you could write about your issues next time anyway, I would be really glad to help you to debug and fix issues 😅