search

victor-torres / atom-hg

Mercurial support for Atom text editor. Works on Linux, Mac OS X and Windows.
https://atom.io/packages/atom-hg
MIT License
27 stars 5 forks source link

Untracked files are appearing as new/added files #31

Open victor-torres opened 8 years ago

victor-torres commented 8 years ago

screen shot 2016-10-08 at 17 41 20

screen shot 2016-10-08 at 17 42 16

I’m not sure these files should be shown in the green color.

victor-torres commented 8 years ago

@TomKemperNL I’ve noticed that untracked files also appear in green using git repositories. What do you think: should we leave it green?

JetBrains shows untracked files in red. Showing these files in green is a mistake IMHO because we tend to think these files are tracked/added and staged for the next commit.

screen shot 2016-10-08 at 18 08 57

victor-torres commented 8 years ago

The pull request #32 now returns whether a path or status is staged or not. This won’t change anything since Atom shows not staged files in green as noticed with git repositories. But we’ll be ready when they start to show it in red or some other text formatting.

victor-torres commented 8 years ago

There’s already an issue for that in Atom’s tree-view plugin repository

I propose the following change:

files which have a red M in the git cli should be orange in tree-view files which have a green M in the git cli should be green in tree-view

https://github.com/atom/tree-view/issues/430

In Mercurial it’s easier to identify untracked files because every removed/modified/added file is automatically staged.