search

victor-torres / atom-hg

Mercurial support for Atom text editor. Works on Linux, Mac OS X and Windows.
https://atom.io/packages/atom-hg
MIT License
27 stars 5 forks source link

Move hgCat, hgId, and hgStatus to hgCommandAsync. #49

Closed Goodwine closed 7 years ago

Goodwine commented 7 years ago

This considerably speeds up atom while typing. moving hgVersion and getHgPathStatus was also considered but it prooved to be quite hard.

With this change, the only synchronous commands happen when opening a project, and when saving a file. I think this should be good enough given that saving a file usually calls a linter or formatter and it takes some time anyways.

I believe deleting hg-repository-async.coffee was better because it wasn't used anywhere and most commands were made async with this PR

Related to: victor-torres/atom-hg#15

victor-torres commented 7 years ago

I’ll review the code tomorrow. After checking out and confirming everything is working, I’ll do the merge.

Thanks for the contribution.