search

victor-torres / atom-hg

Mercurial support for Atom text editor. Works on Linux, Mac OS X and Windows.
https://atom.io/packages/atom-hg
MIT License
27 stars 5 forks source link

Support for Atom 1.7 #9

Closed mrstebo closed 8 years ago

mrstebo commented 8 years ago

Atom 1.7 has introduced async repositories. An error occurrs on this line on the status-bar package because we are missing an async respository.

It mentions that they will be depreciating the GitRepository so I am attempting to write an async version of the HgRepository.

Here is how atom currently adds the async repository.

victor-torres commented 8 years ago

I had those tabs opened when you created this issue. It was the first thing I saw when I first opened Atom today. Are you planning in write another pull request for this?

victor-torres commented 8 years ago

This would help @BlaM with his issue #3

victor-torres commented 8 years ago

I'm working on it.

victor-torres commented 8 years ago

The plugin is working again, but I'm having some troubles with tree-view. Hope in an hour it's solved.

mrstebo commented 8 years ago

Yeah sorry, I have created a HgRepositoryAsync class, but doesn't seem to be working yet...but no errors popping up :fearful:

victor-torres commented 8 years ago

Lets keep running together.

mrstebo commented 8 years ago

Agreed! Won't have chance to work on it tonight. But I'll have another go at it tomorrow at some point

victor-torres commented 8 years ago

@mrstebo can you checkout the async branch and test it on your machine before we release version 2.0.0 please?

mrstebo commented 8 years ago

Sure. I'll give it a test in the morning and let you know how things go. The big test will be if it works on my work machine. Some nice big repos on there :grin:

mrstebo commented 8 years ago

Looks nice! Pretty much how I coded it 😄. Unfortunately I left my code in the office 😩.

victor-torres commented 8 years ago

Nice @mrstebo. I'll just release version 2.0.0 and if you find any bug or have an enhancement tomorrow it could be released in the next 2.0.1 version or sth. like that. Thanks for your support once again.