search

victor / whereami

get your location from the command line
http://victor.github.io/whereami/
MIT License
213 stars 24 forks source link

Improve installation step to use https #14

Closed joelparkerhenderson closed 9 years ago

joelparkerhenderson commented 9 years ago

Using https:// is easier that git@ for public installations, because there's no password prompt.

victor commented 9 years ago

Thanks for the patch, Joel. However if you're worried about the password prompt, I'd rather use git:// than https://

That being said, I'm not sure it is really needed. Most users savvy enough to build from source will already have a github account (with cached credentials and whatnot). For those who don't, it's generally easier to use Homebrew anyway.

joelparkerhenderson commented 9 years ago

Thanks. It's not that I'm worried about it, it's that when you use "git" and the user (e.g. me) has git credentials that require a password, then when I script an installation, it blocks needing my password. Whereas changing to HTTPS doesn't need a password.

GitHub recommends changing to HTTPS (https://help.github.com/articles/which-remote-url-should-i-use/) because it's smarter i.e. GitHub figures the permissions correctly.