search

victor78 / yii2-zipper

Archiving extention for Yii2 Framework - zip, tar, tar.gz, tar.bz2, 7zip
MIT License
1 stars 2 forks source link

Do you have a plan to upgrade the zipper code to PHP v8.0? #2

Open sahilr2050 opened 1 year ago

sahilr2050 commented 1 year ago

Do you have a plan to upgrade the zipper code to PHP v8.0?

victor78 commented 1 year ago

@sahilr2050 Good idea, I did not think about it. As I understand, symfony extentions, which zipper depends on, don't allow to just upgrade. Right?

sahilr2050 commented 1 year ago

This is the error I am getting while upgrading the code to PHP v8.0

Composer code version:

"victor78/yii2-zipper": "^0.0.4",

yii\base\ErrorException: During inheritance of ArrayAccess: Uncaught yii\base\ErrorException: Return type of Alchemy\Zippy\Adapter\AdapterContainer::offsetExists($offset) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily suppress the notice in {project_path}\vendor\alchemy\zippy\src\Adapter\AdapterContainer.php:165

Stack trace:
#0 {project_path}\vendor\alchemy\zippy\src\Adapter\AdapterContainer.php(28): yii\web\ErrorHandler->handleError(code: '8192', message: ''Return type of...', file: ''{project_path}...', line: '165')
#1 {project_path}\vendor\composer\ClassLoader.php(122): Composer\Autoload\ClassLoader->unknown()
#2 {project_path}\vendor\composer\ClassLoader.php(443): Composer\Autoload\ClassLoader::Composer\Autoload\{closure:{project_path}\vendor\composer\ClassLoader.php:121-123}(file: ''{project_path}...')
#3 {project_path}\vendor\victor78\zippy-ext\src\Adapter\AdapterContainer.php(29): Composer\Autoload\ClassLoader->loadClass(class: ''Alchemy\\\\Zippy...')
#4 {project_path}\vendor\composer\ClassLoader.php(122): Composer\Autoload\ClassLoader->unknown()
victor78 commented 1 year ago

@sahilr2050 I got it. I'll upgrade the package in 1-2 weeks (on weekends).