search

victorbalssa / abacus

🟠 Abacus: Firefly III mobile application.
https://apps.apple.com/us/app/1627093491
GNU General Public License v3.0
566 stars 42 forks source link

BUG: Workflow token handling not completing #197

Closed Kage1 closed 10 months ago

Kage1 commented 1 year ago

Describe the bug A continuation of #170.

The token timed out again and it kept the URL this time, but the Client ID and secret fields were blanked out.

To Reproduce

  1. Enter URL, token and secret
  2. Access instance
  3. Wait till the token times out
  4. App throws an error when attempting to refresh it.

Expected behavior Token gets refreshed and data is available.

Screenshots Abacus Error 111823

Smartphone (please complete the following information):

Additional context Saw this on both of my devices, same type, same OS.

Kage1 commented 1 year ago

Forgot this in the original post, after adding the ID and secret the client connected as expected.

Kage1 commented 1 year ago

One more update: So, on my other device it threw the error above. After closing the app and going back into it, it connected and I got the email from FF3 that a new token was created. Not sure what to make of this.

victorbalssa commented 1 year ago

Thanks @Kage1!

One more update: So, on my other device it threw the error above. After closing the app and going back into it, it connected and I got the email from FF3 that a new token was created. Not sure what to make of this.

-> After closing the app it connected you, without needing to enter anything (OAuth id/secret) ?

Kage1 commented 1 year ago

Thanks @Kage1!

One more update: So, on my other device it threw the error above. After closing the app and going back into it, it connected and I got the email from FF3 that a new token was created. Not sure what to make of this.

-> After closing the app it connected you, without needing to enter anything (OAuth id/secret) ?

Yea it connected and shortly after I got the token issued email, this was on device 2.

On device 1 I manually reentered it but my guess is it would have worked also on the 2nd try.

Kage1 commented 11 months ago

An update, this morning it threw the error since the token has timed out. I did get the email from ff3 that a new token was issued, but the Aba login wouldn't update till I put the ID and Secret back in. After that I got another email that another token was issued.

Aba-Login

victorbalssa commented 10 months ago

Version 0.11.1 we be available soon and should fix this bug, let me know if there is still the same error.

Kage1 commented 10 months ago

An observation,

There is a breaking change, the redirect URL changed from:

abacusiosapp://redirect to abacusfiiiapp://redirect

At least for the Android app.

I'll see In a few weeks how it goes with the token refresh issue.

victorbalssa commented 10 months ago

Yes I forgot to mention this in the changelog, you need to update the redirect URL (here) to abacusfiiiapp://redirect in order to login again via OAuth. All current token should still work as expected but next time you login it will throw an error if you use the old abacusiosapp scheme.