victorbalssa / abacus

🟠 Abacus: Firefly III mobile application.
https://apps.apple.com/us/app/1627093491
GNU General Public License v3.0
525 stars 38 forks source link

Bug: Cannot delete credentials #305

Closed Armastardo closed 2 months ago

Armastardo commented 2 months ago

Describe the bug On the credentials screen, using the "Edit" function and trying to delete store credentials doesn't work. Additionally, there's no option to remove credentials from the configuration, only on app startup.

To Reproduce Steps to reproduce the behavior:

  1. Start the app. Shows the Credentials screen.
  2. Click on Edit
  3. Try to remove a credential.
  4. Pick "Delete" when asked "Are you sure2
  5. Nothing happens

Expected behavior Credential should be deleted.

Smartphone (please complete the following information):

hamza-fadil commented 2 months ago

Hi Victor, I believe I have a fix that could solve the issue in my branch : https://github.com/victorbalssa/abacus/compare/develop...hamza-fadil:abacus:hfadil/cleanup I didn't have the time to try it thoroughly due to lack of time lately It's mainly due to an issue with piggybanks not being reset correctly I'll open the PR; was planning to include it with a new feature