Feature Request: When creating a new transaction, it is recommended to turn the submit button gray after clicking it to prevent duplicate transaction creation after multiple clicks

victorbalssa / abacus

🟠 Abacus: Firefly III mobile application.

https://apps.apple.com/us/app/1627093491

GNU General Public License v3.0

566 stars 42 forks source link

Feature Request: When creating a new transaction, it is recommended to turn the submit button gray after clicking it to prevent duplicate transaction creation after multiple clicks #318

Open s4w4j4 opened 4 months ago

s4w4j4 commented 4 months ago

marcelweikum commented 4 months ago

There is a button in the settings screen, which prevents double transactions by closing the transaction form after submitting.

https://github.com/victorbalssa/abacus/blob/31b3515892da7e59f85e8b9fc8728d7a5f76d2fe/src/components/Screens/ConfigurationScreen.tsx#L286-L307

https://github.com/victorbalssa/abacus/blob/31b3515892da7e59f85e8b9fc8728d7a5f76d2fe/src/i18n/locale/translations/en-US.ts#L152-L153

EDIT: spamming the button does indeed still duplicate items if exploited.

s4w4j4 commented 4 months ago

Thank you, I have enabled this option. I'm sorry, it didn't solve the problem mentioned.

Due to the inability to confirm whether the submit button has been successfully clicked, there are situations where the submit button has been clicked multiple times, resulting in duplicate bill creation.

marcelweikum commented 3 months ago

Hey @victorbalssa,

I can take care of that.

Best, Marcel