victorbonnet / flutter_web_browser

Plugin for flutter to open web page with Chrome Custom Tabs and SFSafariViewController
MIT License
62 stars 40 forks source link

openWebPage doesn't return #12

Open passsy opened 4 years ago

passsy commented 4 years ago

await FlutterWebBrowser.openWebPage(url: url); hangs forever

https://github.com/victorbonnet/flutter_web_browser/blob/2eb43f186f36bfe26c1a234951f6ec486daeb022/android/src/main/java/dev/vbonnet/flutterwebbrowser/FlutterWebBrowserPlugin.java#L42-L53

result is unused and never completes the platform channel call.

It should at least result.success("launched") be called after successfully launching the intent.