`PHttpServer` and `PFtpServer` won't be stopped

victordiaz / PHONK

PHONK is a coding playground for new and old Android devices

https://phonk.app

GNU General Public License v3.0

461 stars 25 forks source link

`PHttpServer` and `PFtpServer` won't be stopped #131

Open notEvil opened 1 year ago

notEvil commented 1 year ago

Hi,

PHttpServer is added to whatIsRunning but doesn't have a __stop method. PFtpServer is not added to whatIsRunning in the first place.

The server classes are pretty different in this regard (maybe use WhatIsRunningInterface, maybe extend ProtoBase which has its own abstract __stop, ...).