search

victordiaz / PHONK

PHONK is a coding playground for new and old Android devices
https://phonk.app
GNU General Public License v3.0
456 stars 27 forks source link

Looper.speed() doesn't reset if it has expired after setting a new value #79

Closed Ulugbeg closed 3 years ago

Ulugbeg commented 3 years ago

Looking at the sourcecode at https://github.com/victordiaz/phonk/blob/master/phonk_apprunner/src/main/java/io/phonk/runner/apprunner/api/other/PLooper.java#L85-L86:

        this.speed = duration;
        if (duration < this.speed) {

It seems as if this code doesn't do what it's intended to do; the condition on line 86 will never be true due to, well, line 85 :)

Love the project!

victordiaz commented 3 years ago

Hi @Ulugbeg I really don't know what I was thinking when I wrote that code :) Fixing it ASAP.

Thanks!

victordiaz commented 3 years ago

I think this issue was resolved, please feel free to reopen it the problem still exists :)