NataliaBondarenko
commented
4 years ago Hello! We may not show the entire list at once, but we suggest the user to select the desired extensions. Please take a look at this code example and write your opinion when you have time. In any case, the changes for the supported types will be in a separate pull request.
def check_supported_types(a):
from count_files.settings import SUPPORTED_TYPES
extensions = [x.strip() for x in a.split(',')]
if len(extensions) == 1:
if extensions[0] in SUPPORTED_TYPES['text']:
print(f'Supported: {extensions[0]}')
else:
print(f'Not supported: {extensions[0]}')
else:
st = set(SUPPORTED_TYPES['text'])
e = set(extensions)
if e == {''}:
print('Not entered any value.')
else:
supported = st.intersection(e)
not_supported = e.difference(st)
if supported:
print(f'Supported: {", ".join(supported)}')
if not_supported:
print(f'Not supported: {", ".join(not_supported)}')
def show_supported_types():
from count_files.settings import SUPPORTED_TYPES, SUPPORTED_TYPE_INFO_MESSAGE
msg = 'SUPPORTED_TYPE_INFO_MESSAGE\n' \
'Press Enter to quit.\n' \
'Enter a single extension or a comma-separated list of extensions ' \
'to check if they are in the list of supported types.\n' \
'Enter ALL to see all supported extensions.\n'
print(msg)
while True:
user_input = input(' > ')
if len(user_input.strip()) == 0:
break
elif user_input == 'ALL':
from count_files.settings import simple_columns
print(simple_columns(SUPPORTED_TYPES["text"], num_columns=4))
break
else:
check_supported_types(user_input.lower())
show_supported_types()Preview:
C:\Users\Net\Count-files>count-files -st
SUPPORTED_TYPE_INFO_MESSAGE
Press Enter to quit.
Enter a single extension or a comma-separated list of extensions to check if they are in the list of supported types.
Enter ALL to see all supported extensions.
> py,foo,txt
Supported: txt, py
Not supported: foo
>
C:\Users\Net\Count-files>I'm currently doing tests for preview functions with the "file" command. This week, I want to finish the preview branch, tests, and documentation. Then we will need to check everything on different operating systems. Check if everything is working correctly. If you are not on vacation or have some free time, we can release the new version in September.
victordomingos
The list is growing and is starting to need some sort of organisation. Currently, it displays 4 columns and 29 lines, with items being sorted alphabetically first by line, them by column. It would be a little more readable if it was sorted alphabetically by column instead.
But grouping by filetypes would probably be a great help, even if it makes the list a bit longer.