search

victoreronmosele / flutter_gradient_generator

An online tool for creating and customizing gradients for use in Flutter applications.
https://fluttergradientgenerator.com
GNU General Public License v3.0
21 stars 5 forks source link

Add flutter_lints, format the code #43

Closed domesticmouse closed 2 years ago

victoreronmosele commented 2 years ago

Hi @domesticmouse, thanks for submitting the PR. I'll take a look, shortly.

victoreronmosele commented 2 years ago

I've been trying to figure out why the Github Action workflow was skipped for this PR.

victoreronmosele commented 2 years ago

It's with this line in the workflow file:

https://github.com/victoreronmosele/flutter_gradient_generator/blob/cac1e93703b168a0aaaa64164c0690e5c0dfc3c6/.github/workflows/firebase-hosting-pull-request.yml#L8

I'll remove it so PRs from forks can trigger the workflow.

victoreronmosele commented 2 years ago

Hi @domesticmouse, could you pull my develop branch into yours so it has the change from PR #45 where the restriction from workflows for forks is removed?

domesticmouse commented 2 years ago

Done and done. You'll need to auth the CI run =)

domesticmouse commented 2 years ago

I’ve got no idea how to fix the CI failure

victoreronmosele commented 2 years ago

It has to do with the fork not having access to the secret: https://github.com/victoreronmosele/flutter_gradient_generator/blob/677cee1bf21a798f14621786671e9bc3e8a897a6/.github/workflows/firebase-hosting-pull-request.yml#L25

Trying to look for a way around this.

victoreronmosele commented 2 years ago

I'll most likely revert #45 so the preview deployment is skipped for forks and just add flutter test to the workflow.

domesticmouse commented 2 years ago

Merged upstream, please re-auth the workflow