search

victorfisac / Physac

2D physics header-only library for videogames developed in C using raylib library.
http://www.victorfisac.com/physac
MIT License
432 stars 28 forks source link

Physac naming and icon #33

Closed raysan5 closed 6 years ago

raysan5 commented 6 years ago

Hi @victorfisac, just noticed Physac icon only includes 16x16, 32x32 and 48x48 versions, directly scaled from the 256x256 .png version provided and physac_icon object does not include .rc properties correctly (just check generated .exe files to see that).

Do you mind if I review icon design following the proposed line but more aligned with raylib iconography?

victorfisac commented 6 years ago

Hi @raysan5 ! Yes, I had some problems trying to understand .rc properties and the icon generating pipeline for executables. Yes, I would be so glad if you review it. I will apply those improvements to other repos (FNode and rPBR).

It can be interesting if you create a .txt with the compiling code to create the rc and final icon file using symbols like RAYLIB_PATH for required paths.

raysan5 commented 6 years ago

Implemented in PR https://github.com/victorfisac/Physac/pull/34