victorgarciaesgi / nuxt-typed-router

🚦Provide autocompletion and typecheck to Nuxt router
https://nuxt-typed-router.vercel.app
MIT License
361 stars 12 forks source link

repository url in package.json is formatted weirdly? #138

Closed thunfisch987 closed 8 months ago

thunfisch987 commented 10 months ago

Describe the bug A clear and concise description of what the bug is.

(i'm currently building and testing a small script for myself, which outputs the repositories when updating the packages, so i can look at the changelogs) I noticed the repository url in the package.json is formatted weirdly?

{
  "repository": {
    "type": "git",
    "url": "git+https://victorgarciaesgi@github.com/victorgarciaesgi/nuxt-typed-router.git"
  },
}

I do not mean the git+ but the https://...@github.com/..., why the ...@?

Expected behavior A clear and concise description of what you expected to happen.

-

Screenshots If applicable, add screenshots to help explain your problem.

-

Environnement infos

Run nuxi infos

-

Your pages folder structure

Run npx tree-node-cli {your page folder path}

-

Your nuxt.config.ts Paste your modules config (and i18n config if you're using it)

-

victorgarciaesgi commented 10 months ago

When I created it I though it was required, i'll check! :)

victorgarciaesgi commented 10 months ago

Can confirm everybody does this, even Vue: https://github.com/vuejs/core/blob/c3087ff2cce7d96c60a870f8233441311ab4dfb4/packages/vue/package.json#L86C1-L86C1

thunfisch987 commented 10 months ago

sorry, i do not mean the git+ in front, that one is normal because it's used to tell the browser/operating system to open it with a Git Application (for example the Github App on mobile) i was confused about the victorgarciaesgi@ in front of the github.com

victorgarciaesgi commented 10 months ago

You're right it's weird, i mean it's a valid url but not the cleanest aha, i'll look into it

victorgarciaesgi commented 8 months ago

sorry it took so long, it's fixed on 3.6.0