search

victorgarciaesgi / regle

Typescript first model-based validation library for Vue 3
MIT License
5 stars 0 forks source link

Collection items are not being marked as "$dirty" #4

Closed martinszeltins closed 5 hours ago

martinszeltins commented 6 hours ago

When you modify an item inside a collection - it does not get marked as dirty. I provided a reproduction and steps to take to reproduce the issue.

1 Fill out the name, gets marked as dirty (good)

2 Add 2 skills and modify the name of one of the skills - does not get marked as dirty (bug)

the "dirtyAny" property is also false but should be true

Reproduction link: https://stackblitz.com/~/github.com/martinszeltins/regle-test-2?file=app.vue

Screenshot: dirty2

victorgarciaesgi commented 6 hours ago

Thanks for the bug report! I'll look 👍

victorgarciaesgi commented 6 hours ago

In your screenshot you're showcasing skill[0].skillName, the 2nd element is correctly updated to dirty

image
martinszeltins commented 6 hours ago

In your screenshot you're showcasing skill[0].skillName, the 2nd element is correctly updated to dirty

Ah, you're right! Sorry about that. Problem solved then 👍🏻