victorgarciaesgi / vue-chart-3

📊 A simple wrapper around Chart.js 3 for Vue 2 & 3
https://vue-chart-3.netlify.app/
MIT License
310 stars 112 forks source link

Make package compatible with charts.js 4.X #138

Open tchiotludo opened 1 year ago

tchiotludo commented 1 year ago

the library is compatible with charts.js 4.X but will failed on npm install with node 18:

npm ERR! code ERESOLVE
npm ERR! ERESOLVE could not resolve
npm ERR! 
npm ERR! While resolving: vue-chart-3@3.1.8
npm ERR! Found: chart.js@4.1.1
npm ERR! node_modules/chart.js
npm ERR!   chart.js@"^4.1.1" from the root project
npm ERR! 
npm ERR! Could not resolve dependency:
npm ERR! peer chart.js@"=> ^3.1.0" from vue-chart-3@3.1.8
npm ERR! node_modules/vue-chart-3
npm ERR!   vue-chart-3@"^3.1.8" from the root project
npm ERR! 
npm ERR! Conflicting peer dependency: chart.js@3.9.1
npm ERR! node_modules/chart.js
npm ERR!   peer chart.js@"=> ^3.1.0" from vue-chart-3@3.1.8
npm ERR!   node_modules/vue-chart-3
npm ERR!     vue-chart-3@"^3.1.8" from the root project
npm ERR! 
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
netlify[bot] commented 1 year ago

Deploy Preview for vue-chart-3 failed.

Name Link
Latest commit 7b31e3b302e075dccd7a2c836e0834f16c08d2d6
Latest deploy log https://app.netlify.com/sites/vue-chart-3/deploys/63ab6aa11dc3b10008a56965
tchiotludo commented 1 year ago

still the issue here, do you plan to maintain this package are we not to fork ? Thanks for the clarification

maxqua72 commented 1 year ago

Please fix this issue, if it's possible. It would be a pity not using charts.js 4.x. Thanks.