victorgz / vscode-salesforce-colorg

VSCode extension to automatically change the workspace colors based on the Salesforce org you're connected to
https://marketplace.visualstudio.com/items?itemName=victorgz.vscode-salesforce-colorg
MIT License
7 stars 1 forks source link

How to avoid settings.json always apearing as changed file in Version Control tab? #3

Open joernflath opened 1 year ago

joernflath commented 1 year ago

Hello,

we're versioning the Workspace level settings.json file, so we can share settings across our team. Obviously to change the color of the bar, it will write into the settings.json, but on a Workspace level.

Is there a possibility to have the changes to "workbench.colorCustomizations" written into the User level settings.json? I have the setting only applied on the User level.

victorgz commented 1 year ago

Hi @joernflath, the first version of the extension was working only on User level, however there was an issue which force us to change the color configuration to Workspace level (#1):

I'm not sure if the workspace shared settings.json config changes a lot in your project, but I would suggest to always ignore the file except when you want to include new rules (that shouldn't be that often I believe). I know it's a bit tedious task, but it's the only possible way I see for now

jlawrence124 commented 1 year ago

Hey @victorgz,

First thanks so much for your hard work on this extension. This will be a big help to my team and I. Is it possible that this workspace setting can be made configurable? I understand there are some issues with multiple windows, but for a lot of users they only work with one window open anyway. Thoughts on this?

victorgz commented 1 year ago

Hi @jlawrence124, thanks for the feedback and happy to hear that the extension is useful for you and your team ! That could be a good solution indeed, to have a configurable option to decide where to store the settings (user or workspace level). I'll try to have a look at it and let you know 😃