search

victorgz / vscode-salesforce-colorg

VSCode extension to automatically change the workspace colors based on the Salesforce org you're connected to
https://marketplace.visualstudio.com/items?itemName=victorgz.vscode-salesforce-colorg
MIT License
7 stars 1 forks source link

Settings scope, foreground color, and window focus activation #4

Open jlawrence124 opened 11 months ago

jlawrence124 commented 11 months ago

Hey @victorgz !

I've added several new features! Let me know if you have any questions or concerns.

  1. Settings scope update - users can now select where settings are saved (user vs workspace settings) demo_settings

  2. Controllable foreground color - users can now (optionally) set foreground color for both activity bar and status bar

    Screenshot 2023-11-04 at 3 09 46 AM

    demo_workspace_option

    demo_without_activity_bar

  3. Settings are now recalculated when changing window focus https://github.com/victorgz/vscode-salesforce-colorg/assets/18340994/78b4783e-3bc1-41e1-8f0c-180dbc2c10f5

victorgz commented 11 months ago

Wow thanks a lot for the PR @jlawrence124 ! I am quite busy lately but I'll book some time in my calendar to have a look at this in detail this week. I'll keep you posted!

jlawrence124 commented 11 months ago

Sure thing, @victorgz ! Take your time, no rush. Also, feel free to reach out if you have any questions or concerns I can address.

jlawrence124 commented 11 months ago

@victorgz

These are all great suggestions! I will get to them ASAP. Thanks again for being open to collaboration on this!

victorgz commented 11 months ago

@jlawrence124 Perfect, no rush!

jlawrence124 commented 11 months ago

ok i think i hit everything, but just let me know if I'm missing something. I am working on automatically removing all color settings if the user changes anything related to the scope (just makes things a bit more user friendly), but will work on that tomorrow.

victorgz commented 10 months ago

Hi @jlawrence124 , thanks again for you contribution, and sorry for the late response (I've been OoO and extremely busy). I've done some tests and I get some inconsistencies when switching workspaces. My configuration is:

If you can see in the GIF, sometimes the configuration is not being loaded when switching from one workspace to another... Issue-user-settings

I was wondering whether there's something asynchronous happening behind the scenes that we're missing? Any idea?

jlawrence124 commented 10 months ago

hey @victorgz ! not a problem! I just moved into a new house last week so i understand 😆 . As for this sticky issue here, I'm going to dive into it this week and see if i can figure out what's going on. Thanks for your patience, will make sure this bug gets squashed 🐛

jlawrence124 commented 10 months ago

Hey @victorgz just getting back around to this now. Moving and the holidays have been a bit hectic. It looks like the issue was coming from the defocusing logic combined with the asynchronous call to check if the focused window is a SF project. Should be fixed and much more performant now!

https://github.com/victorgz/vscode-salesforce-colorg/assets/18340994/102dbc91-7c4f-4ced-9cba-7919409ca972

Also found a small bug and squashed it where the initial config would apply even if the window wasn't focused. ^ will get back to this, looks like it was causing some issues

If this is good, let me know and I'll draft up some changes to the README