search

victorhoang07 / Oobr-Eats

https://oobr-eats.herokuapp.com/#/
0 stars 0 forks source link

User Auth #2

Closed keginzburg closed 2 years ago

keginzburg commented 2 years ago

Solid work so far! There's a few issues with User Auth currently.

  1. With window sized/optimized for a 13" Macbook, the SignUp form and Login form seem to be centered towards the bottom of the window.
  2. Upon trying to sign up with empty fields or valid credentials, the Sign Up form renders a 500 Internal Server Error. Accurate session errors should be implemented. User should be able to sign up as well with valid credentials.
  3. Upon trying to login, the same error as above (2) occurs when using invalid credentials. However, the live site breaks and the console logs Uncaught TypeError: e.errors.map is not a function. I would double check what e.errors dataType is. Due to these errors, I can't currently test Login as I can't Sign Up.
  4. Demo Login button is currently a dead button.

I know you are probably aware of these issues as you're still polishing your User Auth and working on Splash, but keep these in mind before you move your User Auth card to Ready for PM Review.

keginzburg commented 2 years ago

Everything here is looking great. Awesome work!