victorhoang07 / Oobr-Eats

https://oobr-eats.herokuapp.com/#/
0 stars 0 forks source link

Splash #3

Open keginzburg opened 2 years ago

keginzburg commented 2 years ago

Just a few notes:

  1. As for pixel perfect, let's try to integrate a font that more closely resembles UberEats font. Let's also make sure that our text stands out against the darker aspects of the splash's background (I'm talking about that zucchini and basil).
  2. Let's also try to integrate a basic footer so you can add your Personal Links there down the line. We don't need to fully replicate UberEats' extensive Footer (Get Help, Buy gift cards, Add your restaurant, Sign up to deliver, etc.), but we do want something to allow space for your GitHub, LinkedIn, and AngelList links. I would try to replicate the styling of UberEats' Facebook, Twitter, and Instagram Icon links in their Footer. They look super clean.
  3. As we go forward, I would try to make the NavBar somewhat dynamic. On UberEats' splash, when scrolling down, the NavBar is sticky. We won't have much scrolling on yours as it stands, so this isn't necessary, but we might need that sticky styling in your RestaurantsIndex.

Altogether, great work! All of these notes are not absolutely necessary for the time being, but please keep them in mind going forward.