victorhurdugaci / SerialProtocol

A protocol for sending data between two Arduino devices, or between an Arduino and another device through a serial port
http://victorhurdugaci.com
Apache License 2.0
41 stars 12 forks source link

Create Arduino Library #3

Closed headHUB closed 6 years ago

headHUB commented 6 years ago

Thank you for this software! It works perfectly. I am new to writing software so I wanted to contribute. I took the repository and made it into an Arduino library so it can be downloaded as a zip file and installed through Arduino menu. I also moved the sample arduino file so that it can ba accessed from the file menu. I am in the middle of writing two more examples and will upload when done.

headHUB commented 6 years ago

hello?

victorhurdugaci commented 6 years ago

hello?

Sorry, I was on vacation :) I'm back now

headHUB commented 6 years ago

Now that I have made changes and committed to my branch, should I create a new request? I've never done this before. This is the first chance I have been able to help with this sort of thing.

victorhurdugaci commented 6 years ago

Congratulations on merging your first PR :)

headHUB commented 6 years ago

Thank you. Ive borrowed so much code from so many places, I'm glad to be able to give back a little.

Get Outlook for Androidhttps://aka.ms/ghei36


From: Victor Hurdugaci notifications@github.com Sent: Sunday, October 14, 2018 6:25:39 PM To: victorhurdugaci/SerialProtocol Cc: James Head; Mention Subject: Re: [victorhurdugaci/SerialProtocol] Create Arduino Library (#3)

Congratulations on merging your first PR :)

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/victorhurdugaci/SerialProtocol/pull/3#issuecomment-429672357, or mute the threadhttps://github.com/notifications/unsubscribe-auth/Ab6XJP9TpQtri68EzR8LzK-9wMDuSlbuks5uk8fzgaJpZM4WaNfE.

{"api_version":"1.0","publisher":{"api_key":"05dde50f1d1a384dd78767c55493e4bb","name":"GitHub"},"entity":{"external_key":"github/victorhurdugaci/SerialProtocol","title":"victorhurdugaci/SerialProtocol","subtitle":"GitHub repository","main_image_url":"https://assets-cdn.github.com/images/email/message_cards/header.png","avatar_image_url":"https://assets-cdn.github.com/images/email/message_cards/avatar.png","action":{"name":"Open in GitHub","url":"https://github.com/victorhurdugaci/SerialProtocol"}},"updates":{"snippets":[{"icon":"PERSON","message":"@victorhurdugaci in #3: Congratulations on merging your first PR :)"}],"action":{"name":"View Pull Request","url":"https://github.com/victorhurdugaci/SerialProtocol/pull/3#issuecomment-429672357"}}} [ { "@context": "http://schema.org", "@type": "EmailMessage", "potentialAction": { "@type": "ViewAction", "target": "https://github.com/victorhurdugaci/SerialProtocol/pull/3#issuecomment-429672357", "url": "https://github.com/victorhurdugaci/SerialProtocol/pull/3#issuecomment-429672357", "name": "View Pull Request" }, "description": "View this Pull Request on GitHub", "publisher": { "@type": "Organization", "name": "GitHub", "url": "https://github.com" } }, { "@type": "MessageCard", "@context": "http://schema.org/extensions", "hideOriginalBody": "false", "originator": "AF6C5A86-E920-430C-9C59-A73278B5EFEB", "title": "Re: [victorhurdugaci/SerialProtocol] Create Arduino Library (#3)", "sections": [ { "text": "", "activityTitle": "Victor Hurdugaci", "activityImage": "https://assets-cdn.github.com/images/email/message_cards/avatar.png", "activitySubtitle": "@victorhurdugaci", "facts": [ ] } ], "potentialAction": [ { "name": "Add a comment", "@type": "ActionCard", "inputs": [ { "isMultiLine": true, "@type": "TextInput", "id": "IssueComment", "isRequired": false } ], "actions": [ { "name": "Comment", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"IssueComment\",\n\"repositoryFullName\": \"victorhurdugaci/SerialProtocol\",\n\"issueId\": 3,\n\"IssueComment\": \"{{IssueComment.value}}\"\n}" } ] }, { "targets": [ { "os": "default", "uri": "https://github.com/victorhurdugaci/SerialProtocol/pull/3#issuecomment-429672357" } ], "@type": "OpenUri", "name": "View on GitHub" }, { "name": "Unsubscribe", "@type": "HttpPOST", "target": "https://api.github.com", "body": "{\n\"commandName\": \"MuteNotification\",\n\"threadId\": 375969732\n}" } ], "themeColor": "26292E" } ]