victorjonsson / Arlima

Article List Manager - Wordpress plugin suitable for online newspapers that's in need of a fully customizable front page
28 stars 16 forks source link

Impossible to edit Arlima list entry after adding article via Post-tab #47

Closed benjitavos closed 10 years ago

benjitavos commented 10 years ago

When adding a post to a Arlima list (by choosing a particular article list) directly from the Posts-tab, the user can't edit post, add label, change format, template etc within the Arlima list management view.

Arlima version deployed: 3.0 beta 34

victorjonsson commented 10 years ago

That sounds strange. What does the js-console say? Does the php error-log say anthing?

victorjonsson commented 10 years ago

Ah, yes this is a bug!

victorjonsson commented 10 years ago

This bug has actually nothing todo with what you're describing. I would advise you to download the latest version from the master branch and check if the problem persists.

If you still get this problem you can add the following to wp-config.php and paste in what is written to the error log (wp-content/debug.log) here when you send the post directly to a list from the Posts-tab and when you open the list in the list-manager.

define('WP_DEBUG', true);
define('WP_DEBUG_LOG', true);

Please also check the js-console in the list manager.

benjitavos commented 10 years ago

Will try that. It is a bit of a mess with the version numbers right now, according to github version 3.0 beta 34 is the latest version from 4th of June, while version 3.0 beta 4 is from 6th of May. But we can of course use the master release and try it out as well. Your latest commit (https://github.com/victorjonsson/Arlima/commit/6f849b3a74745adcfa742df95c18b75fb926cfdb) pushes the version to beta 41 which makes a bit more sense actually :)

victorjonsson commented 10 years ago

yeah... the build script didn't add a leading zero to beta 4, I have fixed that now.

Let me know if the problem won't go away after updating to the latest from the master branch. (The stable 3.X version will probably be released soon after that the summer vacations has ended).

benjitavos commented 10 years ago

We did a test with the latest version from master and the issue is still valid unfortunately. Let me try to summarize the steps we take so that you can try to reproduce it:

  1. Create a new post via the [Posts] tab
  2. Provide a title and some dummy content
  3. Publish the post
  4. On that same Post view, under section "Arlima", assign the post to one of the existing Arlima lists
  5. A popup comes up asking "Are you sure you want to insert this post in the top of selected article list?", select "OK"
  6. Open [Manage lists] tab
  7. Select the added post from the list
  8. Try changing "Entry word"
  9. Try changing [Settings]->format and [Settings]->template to something else than default (we have created a couple of them for our project)
  10. Press the save/publish list button
  11. Browse to the page connected to the list
  12. The changes are not taken into account
  13. Go back to the [Manage lists] tab in wp-admin
  14. Reload the page and once again select the post from the list
  15. Now you can see that the made changes are not saved for some reason

Step 15 above is only valid if the post/article is added via the [Posts] view. The same issue does not appear if the post is added via the [Manage lists] tab by search an article and dragging and dropping into a list.

victorjonsson commented 10 years ago

Okey, I'm able to reproduce this... will check into it

benjitavos commented 10 years ago

The fix works great, thanks a lot @victorjonsson!