search

victorjonsson / Arlima

Article List Manager - Wordpress plugin suitable for online newspapers that's in need of a fully customizable front page
28 stars 16 forks source link

Infinite loop fix #66

Closed aaslun closed 9 years ago

aaslun commented 9 years ago

Fix for possible infinite loop issue if the post has an empty excerpt while attempting to convert it to an Arlima Article with the postToArlimaArticle function.

chredd commented 9 years ago

This looks like a "broken" Pull Request? Lots of files and commits not related to the topic of the PR.

aaslun commented 9 years ago

Hmm.. yes, so it seems. Apparently there's a lot of files that are marked as different due to changed file modes. Sorry, that was not my intention.

chredd commented 9 years ago

Ah, a Git classic. :)

victorjonsson commented 9 years ago

There's much more stuff than changed file permissions, it seems that your branch has diverged quit a lot from the master branch... I will see if I can cherry-pick your latest commit.

victorjonsson commented 9 years ago

I have cherry-picked the fix now. It's no problem to cherry-pick smaller adjustments but it becomes a pain if there's many commits or larger commits.

You should consider Andreas to figure out what features Arlima has to have inorder to enable you to do the customizations you want. Then implement those features in the master branch, move your specific implementation to your theme and finally move back to the master branch of Arlima in your project.

victorjonsson commented 9 years ago

Btw, if you have an idea that feels general anough you can also make a feature-request issue and let us discuss it.

I actually have an idea about how to make the article form in the list manager more configurable. Will create an issue about it.