search

victorjonsson / Arlima

Article List Manager - Wordpress plugin suitable for online newspapers that's in need of a fully customizable front page
28 stars 16 forks source link

Broken JavaScript flow in admin panel when there's no format registered #82

Closed drawski closed 9 years ago

drawski commented 9 years ago

Unregistering all default article formats using arlima_unregister_format() PHP function results with following JavaScript error (on wp-admin/admin.php?page=arlima-main page): 2015-01-14_1541

Maybe it should be checked in ArlimaArticleForm.init() whether $formatSelect variable is not empty before executing ArlimaArticleSettingsMenu.addSelect()?

Following fix in ArlimaArticleForm.js works fine for me:

if ($formatSelect.length > 0) {
    ArlimaArticleSettingsMenu.addSelect($formatSelect);
}
drawski commented 9 years ago

The fix was merged into master: https://github.com/victorjonsson/Arlima/pull/83 Maybe we could close the issue then?

victorjonsson commented 9 years ago

yes, sir!