victorjonsson / Arlima

Article List Manager - Wordpress plugin suitable for online newspapers that's in need of a fully customizable front page
28 stars 16 forks source link

Add support for having the title size slider active without the html_title field #87

Closed awikell closed 9 years ago

awikell commented 9 years ago

I have a use case where I don't want to use the {{html_title}} in my template since this always results in the title being wrapped in an <a> tag. This prevents me from wrapping any of the title's parent elements in an <a> tag itself since nested link elements are forbidden.

I can circumvent this using {{title}} but then the slider for the size of the title is disabled in the list manager, even if my template file also includes {{size}}. I therefor propose that line 157 in ArlimaTemplateLoader.js:

supports['title'] = templateContent.indexOf('{{html_title}}') > -1;

is altered to work similarly to the previous line (156) which checks for editor support:

supports['title'] = templateContent.indexOf('{{html_title}}') > -1 || templateContent.indexOf('{{title}}') > -1;
victorjonsson commented 9 years ago

Agree...

victorjonsson commented 9 years ago

Quick fix :)

chredd commented 9 years ago

Great stuff!

On Thursday, February 19, 2015, Victor Jonsson notifications@github.com wrote:

Quick fix :)

— Reply to this email directly or view it on GitHub https://github.com/victorjonsson/Arlima/issues/87#issuecomment-75135865.

MVH Christoffer Larsson @chredd

awikell commented 9 years ago

That was quick :) Thanks!