victorjonsson / jQuery-Form-Validator

[DISCONTINUED] jQuery plugin that makes it easy to validate user input while keeping your HTML markup clean from javascript code.
972 stars 476 forks source link

No immediate validation state switch from error to success when typing #683

Open lllopo opened 6 years ago

lllopo commented 6 years ago

I'm making a switch from an old version (fifty-something) to the latest. First of all, let me notice that this commit is a huge regression in my view - it prevents from styling properly the labels for example (doesn't mentioning it broke all my setup and styles, but that's my problem) . I'd rather suggest you to allow as an option, to add a separate class (validation-success/error-group for example) to the 'form-group' of each input, so people who need this, like me can apply proper styling to labels and stuff depending on the validation state. Anyway, I also noticed a weird behavior that looks like a bug to me - when you type in a box, the 'error' state (classes, message and all) is set immediately as you type, but the 'success' state is set only after you blur the input. This is very unpleasant and definitely was working properly before, as I'm comparing my production version with the current one. I'm using a custom 'inlineErrorMessageCallback', but still - it is working as intended with the old version without any changes.

lllopo commented 6 years ago

Ok, my bad, just found out, that the new validator version does not play well with another 3rd party script that capitalizes the letters in the input on the fly. So, you can scrap that out. Overall - the validate-as-you-type does not always kick in, have that in mind, can't reproduce it in a stable way, though. The suggestion on custom classes for the 'form-group' remains, though - would be very useful in my view.