victorlaiyeeteng / pe

0 stars 0 forks source link

Duplicate emails allowed for staff #3

Open victorlaiyeeteng opened 10 months ago

victorlaiyeeteng commented 10 months ago

Steps: Added "John Doe" with email "hello@gomail.com" -> added a different staff "Ben John" with the same email "hello@gomail.com"

While I was allowed to add the second staff with the same email, Tran$act should have not allowed that and threw an error as under real-world constraints, no 2 people have the same email. (but it is possible to explain a scenario in the UG where 2 children are sharing the same parent's email)

Screenshot 2023-11-17 at 4.23.26 PM.png

nus-se-script commented 10 months ago

Team's Response

Reasonable concern as two people should not share a same email.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: I feel that this is essential to uniquely identify a staff for proper functionality. Without this unique identifier of email, users may mistakenly send an email (furthermore with this app handling money sensitive transactions) to the wrong user as 2 different people are allowed to be added with the same email.