search

victornpb / eleventy-plugin-page-assets

MIT License
21 stars 16 forks source link

fix variable assignment error #2

Open maxboeck opened 3 years ago

maxboeck commented 3 years ago

Hi! Thanks for this plugin, looks like a good solution to the ongoing 11ty issue about post folders. I noticed a small bug though - when running in "directory" mode, I'm seeing this error:

TemplateWriterWriteError was thrown: Assignment to constant variable.

this is caused by the re-assignment of assets on L110. Declaring it as a mutable variable seems to fix the issue.

KevinGimbel commented 3 years ago

I'm running into the same error. Changing from const to let fixes the issue.

Any estimate when this can be merged and released?

arrowtype commented 3 years ago

Oh, haha, I found and fixed the same thing, and was about to make my own PR. Glad someone beat me to it! See issue #1, which this will close.

hidegh commented 3 years ago

@victornpb any chance to get this fixed? getting same error (also added post.zip content to emulate): https://github.com/victornpb/eleventy-plugin-page-assets/issues/3

walpolea commented 3 years ago

Any chance this fix could get merged in @victornpb?

scsskid commented 3 years ago

please merge

nachtfunke commented 2 years ago

Is there anything we can do to have this request merged?