search

victornpb / undiscord

Undiscord - Delete all messages in a Discord server / channel or DM (Easy and fast) Bulk delete
https://victornpb.github.io/undiscord
MIT License
5.3k stars 721 forks source link

Can't let it run over night since the first brief internet hiccup makes it permanently stop #652

Open ell1e opened 1 month ago

ell1e commented 1 month ago

Undiscord Version

5.2.3

Browser

Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/126.0.0.0 Safari/537.36 OPR/112.0.0.0

Extension

ViolentMonkey v2.20.0

Reproduction steps

  1. Have shaky internet (or alternatively, just briefly turn off your wifi for a few seconds to test this)
  2. Run longer deletion process
  3. At some point it will stop, saying something like: Search request threw an error: {"stack":"TypeError: Failed to fetch\n at https://discord.com/assets/sentry.0b78d0965d28d3959598.js:23:4806\n at UndiscordCore.search (chrome-extension://jinjaccalgkegednnccohejagnlnfdag/Undiscord.user.js#1:655:21)\n at UndiscordCore.run (chrome-extension://jinjaccalgkegednnccohejagnlnfdag/Undiscord.user.js#1:555:19)\n at async HTMLButtonElement.startAction (chrome-extension://jinjaccalgkegednnccohejagnlnfdag/Undiscord.user.js#1:1513:8)","message":"Failed to fetch"} CoreException {"stack":"TypeError: Failed to fetch\n ...

At that point, it won't continue.

Actual results

Deletion process stops with an error if for a few seconds, the internet hangs

Expected results

Deletion process resumes after brief internet hang so that it doesn't need constant baby-sitting to keep going. It should retry for a least a few minutes, or there should be an easy to find option for it to do so

Bug affects

Additional information & file uploads

I don't really have anything else to add, but feel free to ask me for more details

ell1e commented 1 month ago

Possibly related: https://github.com/victornpb/undiscord/issues/540 (Sometimes it stops like described in that one, pretending it was successful when there are many hundred of things remaining. And I assume the solution for both issues might look similar, although my apologies if that isn't the case.)