search

victorolinasc / junit-formatter

A JUnit XML report exporter for Elixir's ExUnit
https://hexdocs.pm/junit_formatter/
Apache License 2.0
110 stars 37 forks source link

Update for Elixir 1.5 compatibility #26

Closed navinpeiris closed 7 years ago

navinpeiris commented 7 years ago

GenEvent is deprecated since Elixir 1.5 and therefore moving the formatter to use GenServer instead.

Fixes https://github.com/victorolinasc/junit-formatter/issues/25

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-75.0%) to 17.308% when pulling 5bc75d9be7ea746dc5bf124e9cfc2cbbc70c1fe2 on navinpeiris:master into 2a1bad963a05dcace4a9ad04314994e25ad27567 on victorolinasc:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-75.0%) to 17.308% when pulling 5bc75d9be7ea746dc5bf124e9cfc2cbbc70c1fe2 on navinpeiris:master into 2a1bad963a05dcace4a9ad04314994e25ad27567 on victorolinasc:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-75.0%) to 17.308% when pulling 5bc75d9be7ea746dc5bf124e9cfc2cbbc70c1fe2 on navinpeiris:master into 2a1bad963a05dcace4a9ad04314994e25ad27567 on victorolinasc:master.

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-75.0%) to 17.308% when pulling 5bc75d9be7ea746dc5bf124e9cfc2cbbc70c1fe2 on navinpeiris:master into 2a1bad963a05dcace4a9ad04314994e25ad27567 on victorolinasc:master.

cs-victor-nascimento commented 7 years ago

Besides the failing tests this seems all right. Will take a look at this more closely later.

ghost commented 7 years ago

Any update on this?

cs-victor-nascimento commented 7 years ago

I am still looking at the test failures. Not sure why on master I can't reproduce. It seems to me like when switiching to a GenServer it leaves the current test suite in a race condition (it fails trying to find files that don't exist because other tests are trying to set envs).

I will probably have to rewrite the way we are testing this. Along the way I will probably remove elixir's 1.1 support too since coveralls demands a 1.2.

Sorry it is taking a while =/

cs-victor-nascimento commented 7 years ago

Well, using asdf I'm reliably triggering the error caught by Travis.

Perhaps we can use a GenServer only for version 1.5. I am still investigating. Just wanted to update here.

cs-victor-nascimento commented 7 years ago

So, I've opted to make a release that made it incompatible with Elixir version lower than 1.4. This way we can use only the GenServer implementation from now on. If people need to support Elixir before 1.4 than use the 1.3 version of the library.

Thanks @navinpeiris for your PR. I thanked you in the release notes as well.