search

victorolinasc / junit-formatter

A JUnit XML report exporter for Elixir's ExUnit
https://hexdocs.pm/junit_formatter/
Apache License 2.0
111 stars 37 forks source link

Generate message using default formatter #33

Closed hauleth closed 6 years ago

hauleth commented 6 years ago

This contains more information about why test have failed, not only raw assertion message, but left and right values as well.

coveralls commented 6 years ago

Coverage Status

Coverage increased (+3.4%) to 97.826% when pulling a186b98d4f946e424f6b35d24ef7606bdbe53db2 on appunite:better-message-formatting into fca8bcaa6fd46a49009a8ea76404c785b3e017b5 on victorolinasc:master.

victorolinasc commented 6 years ago

This looks very nice and is indeed a welcome addition. I can't review it now, but tests are failing. Could you check that?

hauleth commented 6 years ago

@victorolinasc I have updated everything to use default result format (even with correct test numbers) within suite. Unfortunately it ended with being much greater rewrite of the project than I anticipated. Sorry for big diff.

victorolinasc commented 6 years ago

This is awesome @hauleth . Thank you very much. This effort is much appreciated.

I'll take some time to review it properly and run it locally in the next 24hs as this is quite interesting for where I work too. This is essentially a one file lib so I appreciate that you didn't create a fork or another one just because of this.

Once again, thank you very much. I hope to get back to you in the following day.

victorolinasc commented 6 years ago

Left a single comment about the option of printing the report path. It should not print by default.

Other than that, thanks once again for your good work on this. The source needed several enhancements (it was one of my first source codes in Elixir...).

victorolinasc commented 6 years ago

Published as 3.0.0: https://hexdocs.pm/junit_formatter/readme.html

Thanks once again!