search

victorolinasc / junit-formatter

A JUnit XML report exporter for Elixir's ExUnit
https://hexdocs.pm/junit_formatter/
Apache License 2.0
110 stars 37 forks source link

updating deps and addressing compiler warnings #39

Closed jeffgrunewald closed 3 years ago

jeffgrunewald commented 3 years ago

This PR addresses minor compile-time upgrade issues with newer versions of Elixir (1.11) and Erlang/OTP.

With 1.11, the compiler throws a warning whenever an application is implicitly used during runtime without being started in :extra_applications or else included in the list of dependencies. Since :xmerl is an Erlang built-in, it seemed the :extra_applications key was optimal way to include this fix.

I also took the liberty of proposing a new version number given the small size of this change but please feel free to modify as required by your preference.

thanks!

coveralls commented 3 years ago

Coverage Status

Coverage decreased (-2.0%) to 96.078% when pulling 98ffc278137e496b49d404f85a00b2cbd6a8543b on jeffgrunewald:master into 9569cb057b624ea31f54ef61523f8e7a99037165 on victorolinasc:master.

victorolinasc commented 3 years ago

Sorry for the long wait and thanks a lot for your contribution!

I think we should switch from applications: to extra_applications: in mix.exs but will merge this as is and experiment a bit more locally!

Once again, thanks for this!

jeffgrunewald commented 3 years ago

No problem; thanks for the library!

victorolinasc commented 3 years ago

Published 3.2.0 wich included a new option/feature!