search

victorolinasc / junit-formatter

A JUnit XML report exporter for Elixir's ExUnit
https://hexdocs.pm/junit_formatter/
Apache License 2.0
111 stars 37 forks source link

Create report directory automatically #44

Closed wingyplus closed 3 years ago

wingyplus commented 3 years ago

Add a new configuration to create :report_dir directory when it's set to true.

Closes #43

victorolinasc commented 3 years ago

That was fast :) THanks a lot!

Can you add this option to the README?

wingyplus commented 3 years ago

That was fast :) THanks a lot!

Can you add this option to the README?

@victorolinasc I add this option to README. But I'm not good at writing English. Please kindly review. :)

victorolinasc commented 3 years ago

Sorry it took so long :) I think we are fine with this... just one test nitpick

wingyplus commented 3 years ago

@victorolinasc Sorry for the late response. I fix the code from your suggestion and add more tests including check File.mkdir_p! should match with :ok to make sure it can create. Please kindly review.

victorolinasc commented 3 years ago

Thanks and sorry for the delay! I will be releasing it now.

wingyplus commented 3 years ago

@victorolinasc thank you 😊