search

victorops / hubot-victorops

Hubot VictorOps Adapter
MIT License
3 stars 5 forks source link

Bot-announce and new redis storage mechanism #15

Closed jm-welch closed 8 years ago

jm-welch commented 8 years ago

Addresses #10, #13, #14

jm-welch commented 8 years ago

Tested this, and both changes are working.

Important

This will break any custom scripts that rely on either the _private.VO_INCIDENT_KEYS list or accessing incident alert data via a simple @robot.brain.get <incNum>.

To update scripts of the latter category, use this instead (replacing 1091 with the actual number in question, though it should be a string):

@robot.brain.get("VO_INCIDENTS")['1091']
splunk-cwanek commented 8 years ago

Trying to get an idea from our customers who would be affected by the breaking change.

jm-welch commented 8 years ago

Want me to resubmit this against the dev branch?

splunk-cwanek commented 8 years ago

Sure, sounds good

jm-welch commented 8 years ago

Closing to resubmit against dev.