search

victorops / hubot-victorops

Hubot VictorOps Adapter
MIT License
3 stars 5 forks source link

Emit on alerts so scripts can act on them #5

Closed ghost closed 8 years ago

ghost commented 9 years ago

Being able to access an alert from a script would be nice. By emitting alert when an alert happens, scripts can act on it.

ghost commented 9 years ago

I also added in putting incident objects in the brain so that scripts can pull that object out if needed.

ghost commented 9 years ago

@charlie-vo any way I could get this looked at?

nicky-isaacs commented 8 years ago

@jcarl sorry for leaving this hanging. This is something we would love to get merged in, but the unbounded alert queue is a no-go. Is there any way we could add some expiration logic to those brain entries? Or perhaps some bounded FIFO behavior

ghost commented 8 years ago

@nicky-isaacs, yeah, let me see what I can whip up.

ghost commented 8 years ago

@nicky-isaacs, I just pushed up a new commit - it will remove incidents from the brain when they are more than a day old. Let me know what you think and if any changes are needed to the functionality. I've lightly tested it.

nicky-isaacs commented 8 years ago

@jcarl awesome. thanks for getting this in, looks good to me. :shipit:

ghost commented 8 years ago

Awesome!