search

victorperin / qr-scanner-cli

A CLI tool to read QR Code from images
https://victorperin.github.io/qr-scanner-cli/
MIT License
73 stars 24 forks source link

feat: add husky commit hook #48

Closed arvidboivie closed 5 years ago

arvidboivie commented 5 years ago

fixes #47

victorperin commented 5 years ago

PS: I've made some changes to the main repo, so don't need to care about those conflics. When you finish, I can resolve them.

arvidboivie commented 5 years ago

@victorperin I slimmed it down a bit and added your suggestions, please have a look!

victorperin commented 5 years ago

Thank you @arvidboivie. I'm looking now.

victorperin commented 5 years ago

@arvidboivie i noticed you forced push those changes. This is a problem on TravisCI, it don't trigger.

Don't need to worry I'll trigger it from here, but my suggestion is to never force push anything (we squash commits if is necessary).

arvidboivie commented 5 years ago

Ah, good to know. Didn’t know it would have an impact since it’s on my fork.

victorperin commented 5 years ago

I've just changed the position of arguments in test:diff, because i was getting no arguments error on findRelatedTests, as lint-staged pass the staged files as arguments.

victorperin commented 5 years ago

Just merged conflics. I tested all hooks and seems to be working correctly. Now we just wait for travis to check the rest of the work. :)

victorperin commented 5 years ago

Thanks for your contribution @arvidboivie. This means a lot! :)

victorperin commented 5 years ago

:tada: This PR is included in version 0.4.0 :tada:

The release is available on:

Your semantic-release bot :package::rocket: