search

victorpimentel / TVShows

TVShows 2 is the easiest way to download your favorite TV shows automatically in you Mac.
http://tvshowsapp.com/
GNU General Public License v3.0
436 stars 105 forks source link

Prioritizing 1080p #61

Open shenanigans12 opened 11 years ago

shenanigans12 commented 11 years ago

I'm experiencing some strange behavior when using the HD filter. It seems to prioritize shows in 720p, for instance, for show A, if I have "HD" checked, it finds and downloads a show in 720p.

Then, I uncheck "HD" and it downloads the same show in 1080p. This tells me that a higher resolution is available, however the filter seems to be prioritizing 720p. Is there a way to prioritize 1080p for HD and then default to 720p if a higher resolution isn't found?

LadyMadonna commented 11 years ago

Hi shenanigans12,

Sorry for the late reply. Unfortunately, currently TVShows takes "720p" in the file name as the only HD indicator, so files with "720p" are considered HD and files with "1080p" are considered SD. This worked while there were no 1080p releases, now that there are we need to reconsider that but I'm not sure this is easy in TVShows 2.0 (I'm not a programmer), so it's possible that this has to wait until TVShows 3.0 (no ETA yet, sorry), which will be rewritten from scratch.

In the meantime, if you find a feed with 720p and 1080p content, you can trick the app by subscribing in SD, it will download the 1080p version and if it doesn't find it in a couple of days it will default to 720p. This will not work if there is SD, 720p and 1080p content in the feed, TVShows would download SD or 1080p indistinctively.

wintercherry commented 11 years ago

Would be nice if it let you choose similar to the way uTorrent allows you to filter RSS by quality (I still find TVShows2 superior to the smart feeds in uTorrent, which is why I'm here complaining and not using that instead). Some sites (e.g. DailyTvTorrents.org) offer multiple versions (720, 1080, or WEB-DL to name a few) of the same episode. However, when a custom RSS feed is used, TVShows2 subsequently downloads all versions of the same episode (it seems to choose the 720p version first, then downloads any others a few hours later). Why it's not marking the episode as already finished is a mystery.

If you cannot add a way to change the preferred version, perhaps it's less work to simply extend the predicate builder to support custom filters on the XML instead of just this hardcoded dropdown containing pubDate, episodeName, etc. These identifiers are sort of useless for custom RSS feeds with different XML element and attribute names anyway. And with this feature, one could, for example, specify outright that he's only interested in the WEB-DL torrents, or only torrents with DD5.1 audio, etc., via expression matching.

MacDada commented 9 years ago

I'm not ObjC programmer, but I tried searching inside the source code to find two occurrences of 720p:

  1. the regexp in parseTitleFromString
  2. the regexp in parseShowFromTitle

BUT, I did find isEpisodeHD with a proper HD matcher (both 720p and 1080p) as well: https://github.com/victorpimentel/TVShows/blob/768196c66a070a912e2ea00ace1a6626769304bc/Classes/TSRegexFun.m#L58

Is this still an issue?