victorprad / InfiniTAM

A Framework for the Volumetric Integration of Depth Images
http://www.infinitam.org
Other
918 stars 351 forks source link

Implement depth and RGB data reading for Kinect v2 #34

Closed Maghoumi closed 6 years ago

Maghoumi commented 8 years ago

Fix blank screen in #33 . Implement "Kinect2Engine::getImages()" for depth and RGB data. Change hard-coded Kinect v2 resolution values to constants.

sgolodetz commented 8 years ago

@Maghoumi: This currently fails to build on Mac OS X:

In file included from /Users/stuart/programs/InfiniTAM/InfiniTAM/Engine/Kinect2Engine.cpp:3:
/Users/stuart/programs/InfiniTAM/InfiniTAM/Engine/Kinect2Engine.h:29:4: error: unknown type name 'RGBQUAD'
                        RGBQUAD* m_pColorRGBX;
                        ^
1 error generated.
Maghoumi commented 8 years ago

@sgolodetz Sorry about that. I was exposing Windows specific stuff in the header file. Can you please try that again?

sgolodetz commented 8 years ago

@Maghoumi: Thanks, that now builds fine on Mac. I think I'm right in saying that it repeatedly allocates and then deallocates memory each frame now though -- might be worth looking at alternatives.

Maghoumi commented 8 years ago

Well the alternative is to redefine RGBQuad somewhere and have it as a member instance (like I had before). If you'd want me to do that let me know. The only question is, where should I define the struct? Is there a specific file you use for struct definitions or is anywhere fine?