search

victorsenam / caderno

10 stars 3 forks source link

Possible bad precision on vec::compare() #1

Closed victorsenam closed 7 years ago

victorsenam commented 7 years ago

Function vec::compare from geometry.cpp may have some precision issues. Stress tests for RotateAndCompare fail if the arguments on this line are (1e-4, 1e4) or even (1e-3,1e4).

Can we do better that this?

victorsenam commented 7 years ago

Also, problem Altars from POI got TL using this :(

victorsenam commented 7 years ago

The comparsion made on sd checks for absolute error and tests were generating vectors with a big module, which causes absolute error to be big, though relative error may still be small.